Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.3k
gh-138515: Include email module in Emscripten build#138520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation
!buildbot emscripten |
bedevere-bot commentedSep 5, 2025
🤖 New build scheduled with the buildbot fleet by@hoodmane for commit1acd7e1 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F138520%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
lgtm
I direclty talked with@ryanking13 that including email again makes Emscripten build situation better, and nothing will affect the CPython itself at this moment.
@ryanking13 Please add NEWS.d that you included this package again, |
@corona10 yup, added it. |
Let me check emcrypten build bot test also :) |
!buildbot emscripten |
bedevere-bot commentedSep 5, 2025
🤖 New build scheduled with the buildbot fleet by@corona10 for commite74afa1 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F138520%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
d1d8409 intopython:mainUh oh!
There was an error while loading.Please reload this page.
Thanks@ryanking13 for the PR, and@corona10 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
GH-138533 is a backport of this pull request to the3.14 branch. |
GH-138534 is a backport of this pull request to the3.13 branch. |
…hongh-138520) (python#138533)Co-authored-by: Gyeongjae Choi <def6488@gmail.com>
Uh oh!
There was an error while loading.Please reload this page.
One line change to include the email module in the Emscripten build so the
importlib.metadatapackage can be imported without an error.importlib.metadata#138515