Done.

I suggest to callos.fspath() for all items before assigning them to TZPATH (and before checking that they are absolute paths). We can also add a check that they all are now strings (bytes object will cause error later infind_tzfile() andavailable_timezones()).

I suggest to call os.fspath() for all items before assigning them to TZPATH (and before checking that they are absolute paths).

We can do that, but I don't think it's really necessary. Checking for absolute status is done withos.path.isabs, which already handles os.PathLike objects correctly. Within our code, TZPATH is consumed byfind_tzfile, which usesos.path.join to produce a string, so it's again automatically handled.

I found this issue while working on a program to apply typeshed stubs to the stdlib and then analyze with mypy, so I'm relatively confident that this is the only place in (python-source) stdlib where os.Pathlike values for TZPATH were overlooked. (Typeshed correctly annotates TZPATH astuple[str | PathLike[str], ...])

This leaves the possibility of third-party consumers of TZPATH being surprised by encountering anos.PathLike object instead of a string. If we want to change TZPATH to be restricted tostr only on that basis, that's probably reasonable, but I think that's probably best left for a different MR.

It will help to check that if it is a path-like object, it isPathLike[str], notPathLike[Any].bytes andPathLike[bytes] in TZPATH will cause runtime error inos.path.join().

Anyway, if os.fspath() is already implicitly called inos.path.isabs() andos.path.join(), why not call it explicitly and save the result?

@serhiy-storchaka Is this about what you were thinking?

Thanks@tungol for the PR, and@serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

Thanks@tungol for the PR, and@serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

Sorry,@tungol and@serhiy-storchaka, I could not cleanly backport this to3.13 due to a conflict.
Please backport usingcherry_picker on command line.

cherry_picker 859aecc33b82f45e5b7ae30138d28f2a2f33a575 3.13

GH-138777 is a backport of this pull request to the3.14 branch.

GH-138778 is a backport of this pull request to the3.13 branch.