Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.4k
[3.14] gh-90548: Fix musl version detection with --strip-all (GH-137864)#138348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
vstinner left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM
cdce8p commentedSep 2, 2025
Thanks@vstinner! Looks like this one is ready for merge now, all checks have passed. |
vstinner commentedSep 2, 2025
This fix will have to wait for Python 3.14.1. It's not special enough to fit into Python 3.14.0 final release. |
cdce8p commentedSep 2, 2025
Ahh, I see. Tbh I had hoped it could still be included as it fixes a regression introduced in6146295 (3.14.0a7). Without the fix I'll need to patch our alpine docker builds for 3.14.0. |
vstinner commentedSep 2, 2025
cc@hugovk |
d36c9a8 intopython:3.14Uh oh!
There was an error while loading.Please reload this page.
…ythonGH-137864) (python#138348)Co-authored-by: Marc Mueller <30130371+cdce8p@users.noreply.github.com>Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Uh oh!
There was an error while loading.Please reload this page.
(cherry picked from commit6528cf4)
Co-authored-by: Marc Mueller30130371+cdce8p@users.noreply.github.com
Co-authored-by: Adam Turner9087854+AA-Turner@users.noreply.github.com