Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

gh-138253: Fix compatibility of sub-interpreters queues with queue.Queue#138256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@serhiy-storchaka
Copy link
Member

@serhiy-storchakaserhiy-storchaka commentedAug 30, 2025
edited by bedevere-appbot
Loading

Add the block parameter in the put() and get() methods of the concurrent.interpreters queues for compatibility with the queue.Queue interface.

…eue.QueueAdd the block parameter in the put() and get() methods ofthe concurrent.interpreters queues for compatibility with thequeue.Queue interface.
…Ehj-N.rstCo-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Copy link
Member

@sobolevnsobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

thanks! this looks like a good solution, fortunatelly we discovered it before 3.14.0 :)

encukou reacted with thumbs up emoji
@gpshead
Copy link
Member

Up to@hugovk to decide if this is worthy of being in a rc. This is a bugfix on an obvious omission within a brand new public API, it'd also make sense for 3.14.1 as well given the 3.14.0rc2 docs already documented that theblock parameter -https://docs.python.org/3.14/library/queue.html#queue.Queue.get

Copy link
Member

@ericsnowcurrentlyericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

@serhiy-storchakaserhiy-storchaka removed the needs backport to 3.13bugs and security fixes labelSep 2, 2025
@serhiy-storchakaserhiy-storchaka merged commitcb18269 intopython:mainSep 2, 2025
51 checks passed
@miss-islington-app
Copy link

Thanks@serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestSep 2, 2025
…eue.Queue (pythonGH-138256)Add the block parameter in the put() and get() methods ofthe concurrent.interpreters queues for compatibility with thequeue.Queue interface.(cherry picked from commitcb18269)Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@serhiy-storchakaserhiy-storchaka deleted the interpreters-queue-block branchSeptember 2, 2025 05:59
@bedevere-app
Copy link

GH-138367 is a backport of this pull request to the3.14 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.14bugs and security fixes labelSep 2, 2025
hugovk pushed a commit that referenced this pull requestSep 8, 2025
…ueue.Queue (GH-138256) (#138367)Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
kumaraditya303 pushed a commit to miss-islington/cpython that referenced this pull requestSep 9, 2025
…with queue.Queue (pythonGH-138256) (python#138367)Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
lkollar pushed a commit to lkollar/cpython that referenced this pull requestSep 9, 2025
…eue.Queue (pythonGH-138256)Add the block parameter in the put() and get() methods ofthe concurrent.interpreters queues for compatibility with thequeue.Queue interface.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@hugovkhugovkhugovk left review comments

@gpsheadgpsheadgpshead approved these changes

@ericsnowcurrentlyericsnowcurrentlyericsnowcurrently approved these changes

@sobolevnsobolevnsobolevn approved these changes

+1 more reviewer

@auvipyauvipyauvipy approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@serhiy-storchaka@gpshead@ericsnowcurrently@hugovk@sobolevn@auvipy

[8]ページ先頭

©2009-2025 Movatter.jp