Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-138239: Fix incorrect highlighting of "type" in type statements in the REPL.#138241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ambv merged 8 commits intopython:mainfrom00ll00:repl-highlight
Sep 15, 2025

Conversation

@00ll00
Copy link
Contributor

@00ll0000ll00 commentedAug 29, 2025•
edited by bedevere-appbot
Loading

  • Add a check for the type statement in functionis_soft_keyword_used.

@python-cla-bot
Copy link

python-cla-botbot commentedAug 29, 2025•
edited
Loading

All commit authors signed the Contributor License Agreement.

CLA signed

@bedevere-app
Copy link

Most changes to Pythonrequire a NEWS entry. Add one using theblurb_it web app or theblurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply theskip news label instead.

00ll00and others added2 commitsAugust 29, 2025 21:25
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
…thZFI.rstCo-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
@picnixz
Copy link
Member

my bad, my suggestion had an extra: (you can just fix it in a separate commit)

@00ll00
Copy link
ContributorAuthor

my bad, my suggestion had an extra: (you can just fix it in a separate commit)

I didn’t notice the issue here, let me fix it. 😊

@00ll00
Copy link
ContributorAuthor

The commit above also fixed the missing handling for type statement after DEDENT, discovered while adding test cases. 😌

@ambvambv merged commit26cfb17 intopython:mainSep 15, 2025
53 checks passed
@ambvambv added the needs backport to 3.14bugs and security fixes labelSep 15, 2025
@miss-islington-app
Copy link

Thanks@00ll00 for the PR, and@ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestSep 15, 2025
…nts in the REPL (pythonGH-138241)(cherry picked from commit26cfb17)Co-authored-by: 00ll00 <40747228+00ll00@users.noreply.github.com>Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
@bedevere-app
Copy link

GH-138937 is a backport of this pull request to the3.14 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.14bugs and security fixes labelSep 15, 2025
@00ll0000ll00 deleted the repl-highlight branchSeptember 16, 2025 04:08
encukou pushed a commit that referenced this pull requestOct 7, 2025
…ents in the REPL (GH-138241) (GH-138937)(cherry picked from commit26cfb17)Co-authored-by: 00ll00 <40747228+00ll00@users.noreply.github.com>Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@ambvambvambv left review comments

@picnixzpicnixzpicnixz left review comments

@lysnikolaoulysnikolaouAwaiting requested review from lysnikolaoulysnikolaou is a code owner

@pablogsalpablogsalAwaiting requested review from pablogsalpablogsal is a code owner

Assignees

@ambvambv

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@00ll00@picnixz@ambv@pablogsal
[8]ページ先頭
©2009-2025 Movatter.jp