Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

gh-137728 gh-137762: Fix bugs in the JIT with many local variables#137764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Fidget-Spinner merged 5 commits intopython:mainfromFidget-Spinner:fix-jit-bottom
Aug 20, 2025

Conversation

@Fidget-Spinner
Copy link
Member

@Fidget-SpinnerFidget-Spinner commentedAug 14, 2025
edited by bedevere-appbot
Loading

It's not really feasible to add a test case for this. As it requires a gigantic frame that just so happens to also pass the frame initialization, but exhaust the symbol arena memory. Furthermore, that test would be tied to the size of the symbol arena, which we will tweak over time anyways, so the test will quickly go out of date.

@Fidget-SpinnerFidget-Spinner changed the titlegh-137728: Fix a bug in the JIT with many local variablesgh-137728 gh-137762: Fix bugs in the JIT with many local variablesAug 14, 2025
@tomasr8tomasr8 self-requested a reviewAugust 20, 2025 09:18
Copy link
Member

@markshannonmarkshannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM.

@Fidget-SpinnerFidget-Spinner merged commit7fda8b6 intopython:mainAug 20, 2025
63 checks passed
@miss-islington-app
Copy link

Thanks@Fidget-Spinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

@Fidget-SpinnerFidget-Spinner deleted the fix-jit-bottom branchAugust 20, 2025 14:53
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestAug 20, 2025
…variables (pythonGH-137764)(cherry picked from commit7fda8b6)Co-authored-by: Ken Jin <kenjin@python.org>
@bedevere-app
Copy link

GH-137999 is a backport of this pull request to the3.14 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.14bugs and security fixes labelAug 20, 2025
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure⚠️⚠️⚠️

Hi! The buildbotARM Raspbian Linux Asan 3.x (no tier) has failed when building commit7fda8b6.

What do you need to do:

  1. Don't panic.
  2. Checkthe buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1811/builds/132) and take a look at the build logs.
  4. Check if the failure is related to this commit (7fda8b6) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1811/builds/132

Failed tests:

  • test_math
  • test_fstring

Summary of the results of the build (if available):

==

Click to see traceback logs
remote:Enumerating objects: 10, done.remote:Counting objects:  14% (1/7)remote:Counting objects:  28% (2/7)remote:Counting objects:  42% (3/7)remote:Counting objects:  57% (4/7)remote:Counting objects:  71% (5/7)remote:Counting objects:  85% (6/7)remote:Counting objects: 100% (7/7)remote:Counting objects: 100% (7/7), done.remote:Compressing objects:  14% (1/7)remote:Compressing objects:  28% (2/7)remote:Compressing objects:  42% (3/7)remote:Compressing objects:  57% (4/7)remote:Compressing objects:  71% (5/7)remote:Compressing objects:  85% (6/7)remote:Compressing objects: 100% (7/7)remote:Compressing objects: 100% (7/7), done.remote:Total 10 (delta 0), reused 0 (delta 0), pack-reused 3 (from 2)From https://github.com/python/cpython * branch                    main       -> FETCH_HEADNote:switching to '7fda8b66debb24e0520b94c3769b648c7305f84e'.You are in 'detached HEAD' state. You can look around, make experimentalchanges and commit them, and you can discard any commits you make in thisstate without impacting any branches by switching back to a branch.If you want to create a new branch to retain commits you create, you maydo so (now or later) by using -c with the switch command. Example:  git switch -c <new-branch-name>Or undo this operation with:  git switch -Turn off this advice by setting config variable advice.detachedHead to falseHEAD is now at 7fda8b66deb gh-137728 gh-137762: Fix bugs in the JIT with many local variables (GH-137764)Switched to and reset branch 'main'configure:WARNING: no system libmpdec found; falling back to pure-Python version for the decimal moduleIn file included from ./Include/internal/pycore_dict.h:11,from Objects/typeobject.c:7:In function ‘Py_DECREF_MORTAL’,    inlinedfrom ‘PyStackRef_XCLOSE’ at ./Include/internal/pycore_stackref.h:730:9,    inlinedfrom ‘_PyThreadState_PopCStackRef’ at ./Include/internal/pycore_stackref.h:810:5,    inlinedfrom ‘vectorcall_maybe’ at Objects/typeobject.c:3108:9:./Include/internal/pycore_object.h:481:8: warning: array subscript 0 is outside array bounds of ‘PyObject[0]’ {aka ‘struct _object[]’} [-Warray-bounds]  481 |     if (--op->ob_refcnt == 0) {|^Timeout (0:05:00)!Thread 0x0000007fa7bff100 [Thread-4] (most recent call first):  File "/home/buildbot/buildarea/3.x.pablogsal-rasp.asan/build/Lib/subprocess.py", line 2057 in _wait  File "/home/buildbot/buildarea/3.x.pablogsal-rasp.asan/build/Lib/subprocess.py", line 1277 in wait  File "/home/buildbot/buildarea/3.x.pablogsal-rasp.asan/build/Lib/test/libregrtest/run_workers.py", line 194 in _run_process  File "/home/buildbot/buildarea/3.x.pablogsal-rasp.asan/build/Lib/test/libregrtest/run_workers.py", line 299 in run_tmp_files  File "/home/buildbot/buildarea/3.x.pablogsal-rasp.asan/build/Lib/test/libregrtest/run_workers.py", line 363 in _runtest  File "/home/buildbot/buildarea/3.x.pablogsal-rasp.asan/build/Lib/test/libregrtest/run_workers.py", line 403 in run  File "/home/buildbot/buildarea/3.x.pablogsal-rasp.asan/build/Lib/threading.py", line 1074 in _bootstrap_inner  File "/home/buildbot/buildarea/3.x.pablogsal-rasp.asan/build/Lib/threading.py", line 1036 in _bootstrapThread 0x0000007fa73ef100 [Thread-3] (most recent call first):  File "/home/buildbot/buildarea/3.x.pablogsal-rasp.asan/build/Lib/subprocess.py", line 1257 in _remaining_time  File "/home/buildbot/buildarea/3.x.pablogsal-rasp.asan/build/Lib/subprocess.py", line 2053 in _wait  File "/home/buildbot/buildarea/3.x.pablogsal-rasp.asan/build/Lib/subprocess.py", line 1277 in wait  File "/home/buildbot/buildarea/3.x.pablogsal-rasp.asan/build/Lib/test/libregrtest/run_workers.py", line 194 in _run_process  File "/home/buildbot/buildarea/3.x.pablogsal-rasp.asan/build/Lib/test/libregrtest/run_workers.py", line 299 in run_tmp_files  File "/home/buildbot/buildarea/3.x.pablogsal-rasp.asan/build/Lib/test/libregrtest/run_workers.py", line 363 in _runtest  File "/home/buildbot/buildarea/3.x.pablogsal-rasp.asan/build/Lib/test/libregrtest/run_workers.py", line 403 in run  File "/home/buildbot/buildarea/3.x.pablogsal-rasp.asan/build/Lib/threading.py", line 1074 in _bootstrap_inner  File "/home/buildbot/buildarea/3.x.pablogsal-rasp.asan/build/Lib/threading.py", line 1036 in _bootstrapThread 0x0000007fb38f36c0 [python] (most recent call first):  File "/home/buildbot/buildarea/3.x.pablogsal-rasp.asan/build/Lib/test/libregrtest/utils.py", line 81 in format_duration  File "/home/buildbot/buildarea/3.x.pablogsal-rasp.asan/build/Lib/test/libregrtest/run_workers.py", line 464 in get_running  File "/home/buildbot/buildarea/3.x.pablogsal-rasp.asan/build/Lib/test/libregrtest/run_workers.py", line 551 in _get_result  File "/home/buildbot/buildarea/3.x.pablogsal-rasp.asan/build/Lib/test/libregrtest/run_workers.py", line 610 in run  File "/home/buildbot/buildarea/3.x.pablogsal-rasp.asan/build/Lib/test/libregrtest/main.py", line 455 in _run_tests_mp  File "/home/buildbot/buildarea/3.x.pablogsal-rasp.asan/build/Lib/test/libregrtest/main.py", line 288 in _rerun_failed_tests  File "/home/buildbot/buildarea/3.x.pablogsal-rasp.asan/build/Lib/test/libregrtest/main.py", line 309 in rerun_failed_tests  File "/home/buildbot/buildarea/3.x.pablogsal-rasp.asan/build/Lib/test/libregrtest/main.py", line 569 in _run_tests  File "/home/buildbot/buildarea/3.x.pablogsal-rasp.asan/build/Lib/test/libregrtest/main.py", line 598 in run_tests  File "/home/buildbot/buildarea/3.x.pablogsal-rasp.asan/build/Lib/test/libregrtest/main.py", line 767 in main  File "/home/buildbot/buildarea/3.x.pablogsal-rasp.asan/build/Lib/test/libregrtest/main.py", line 775 in main  File "/home/buildbot/buildarea/3.x.pablogsal-rasp.asan/build/Lib/test/__main__.py", line 2 in <module>  File "<frozen runpy>", line 88 in _run_code  File "<frozen runpy>", line 198 in _run_module_as_mainmake:*** [Makefile:2494: buildbottest] Error 1Cannot open file '/home/buildbot/buildarea/3.x.pablogsal-rasp.asan/build/test-results.xml' for upload

hugovk pushed a commit that referenced this pull requestAug 21, 2025
kumaraditya303 pushed a commit to miss-islington/cpython that referenced this pull requestSep 9, 2025
… local variables (pythonGH-137764) (python#137999)Co-authored-by: Ken Jin <kenjin@python.org>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@markshannonmarkshannonmarkshannon approved these changes

@brandtbucherbrandtbucherAwaiting requested review from brandtbucher

@tomasr8tomasr8Awaiting requested review from tomasr8tomasr8 is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Fidget-Spinner@bedevere-bot@tomasr8@markshannon

[8]ページ先頭

©2009-2025 Movatter.jp