NotificationsYou must be signed in to change notification settings
Fork33.3k
Star69.7k

[3.14] gh-137400: Fix thread-safety issues when profiling all threads (gh-137518)#137730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

colesbury merged 3 commits intopython:3.14fromcolesbury:backport-a10152f-3.14

Oct 7, 2025

Merged

[3.14] gh-137400: Fix thread-safety issues when profiling all threads (gh-137518)#137730

colesbury merged 3 commits intopython:3.14fromcolesbury:backport-a10152f-3.14

Oct 7, 2025

Conversation

Copy link

Contributor

colesbury commentedAug 13, 2025•
edited by bedevere-appbot
Loading

There were a few thread-safety issues when profiling or tracing all threads via PyEval_SetProfileAllThreads or PyEval_SetTraceAllThreads:

The loop over thread states could crash if a thread exits concurrently (in both the free threading and default build)
The modification ofc_profilefunc andc_tracefunc wasn't thread-safe on the free threading build.

(cherry picked from commita10152f)

Issue:sys._setprofileallthreads race condition #137400

[3.14]pythongh-137400: Fix thread-safety issues when profiling all t…

a4b3a4b

…hreads (pythongh-137518)There were a few thread-safety issues when profiling or tracing allthreads via PyEval_SetProfileAllThreads or PyEval_SetTraceAllThreads:* The loop over thread states could crash if a thread exits concurrently  (in both the free threading and default build)* The modification of `c_profilefunc` and `c_tracefunc` wasn't  thread-safe on the free threading build.(cherry picked from commita10152f)Co-authored-by: Sam Gross <colesbury@gmail.com>