NotificationsYou must be signed in to change notification settings
Fork33.4k
Star69.8k

gh-132339: Add support for OpenSSL 3.5#137720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

zware merged 8 commits intopython:mainfromzware:ssl35

Aug 14, 2025

Merged

gh-132339: Add support for OpenSSL 3.5#137720

zware merged 8 commits intopython:mainfromzware:ssl35

Aug 14, 2025

Conversation

Copy link

Member

zware commentedAug 13, 2025•
edited by bedevere-appbot
Loading

Includes_ssl_data*.h update, as well as updating other versions in CI.

Issue:Add OpenSSL 3.5 support to CPython infrastructure #132339

zware added6 commits

August 13, 2025 11:51

pythongh-132339: Add OpenSSL 3.5.2 definitions to Modules/_ssl_data_35.h

4af3c50

Demote OpenSSL 3.1 to "old"

e492481

Update OPENSSL_RECENT_VERSIONS

5c929b2

Add 3.5.2 to OPENSSL_RECENT_VERSIONS

1c15b2f

Fix argument parser description in multissltests.py

62e4ff3

Add blurb

5a7f52e

bedevere-appbot mentioned this pull request

Aug 13, 2025

Add OpenSSL 3.5 support to CPython infrastructure#132339

Closed

AA-Turner reviewed

Aug 13, 2025

View reviewed changes

Tools/ssl/multissltests.py OutdatedShow resolvedHide resolved

zware commented

Aug 13, 2025

View reviewed changes

.github/workflows/build.yml OutdatedShow resolvedHide resolved

zware marked this pull request as ready for review

August 13, 2025 17:43

zware requested review fromezio-melotti,gpshead,hugovk andpicnixz ascode owners

August 13, 2025 17:43

bedevere-appbot added the awaiting core review label

Aug 13, 2025

zware added2 commits

August 13, 2025 14:13

fixup! Fix argument parser description in multissltests.py

954c4b5

Drop OpenSSL 3.1 from CI

f665e8a

gpshead approved these changes

Aug 14, 2025

View reviewed changes

bedevere-appbot added awaiting merge and removed awaiting core review labels

Aug 14, 2025

gpshead added needs backport to 3.13

bugs and security fixes

needs backport to 3.14bugs and security fixes labels

Aug 14, 2025

zware merged commit7a703c8 intopython:main

Aug 14, 2025

87 of 89 checks passed

zware deleted the ssl35 branch

August 14, 2025 04:18

bedevere-appbot removed the awaiting merge label

Aug 14, 2025

Copy link

miss-islington-appbot commentedAug 14, 2025

Thanks@zware for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

Copy link

miss-islington-appbot commentedAug 14, 2025

Sorry,@zware, I could not cleanly backport this to3.14 due to a conflict.
Please backport usingcherry_picker on command line.

cherry_picker 7a703c8f1942c8bd07943458962f6e59d2892757 3.14

Copy link

miss-islington-appbot commentedAug 14, 2025

Sorry,@zware, I could not cleanly backport this to3.13 due to a conflict.
Please backport usingcherry_picker on command line.

cherry_picker 7a703c8f1942c8bd07943458962f6e59d2892757 3.13

zware added a commit to zware/cpython that referenced this pull request

Aug 14, 2025

[3.14]pythongh-132339: Add support for OpenSSL 3.5 (pythonGH-137720)

209d383

* Add OpenSSL 3.5.2 definitions to Modules/_ssl_data_35.h (moved from Modules/_ssl_data_34.h)* Demote OpenSSL 3.1 to "old", remove it from CI* Update all OpenSSL versions to latest patchlevel in CI config and multissltests defaults* Add OpenSSL 3.5.2 to CI configuration and multissltests default list* Fix a typo in the argument parser description of multissltests.py(cherry picked from commit7a703c8)Co-authored-by: Zachary Ware <zach@python.org>

Copy link

bedevere-appbot commentedAug 14, 2025

GH-137747 is a backport of this pull request to the3.14 branch.

bedevere-appbot removed the needs backport to 3.14bugs and security fixes label

Aug 14, 2025

Copy link

MemberAuthor

zware commentedAug 14, 2025

The 3.13 backport is complicated by the fact that 3.4 support was not backported there; presumably we want to do that first? I think we do want to make sure 3.5 at least works back to 3.13 (maybe even further?), but how critical is the_ssl_data*.h update for that?

cc:@encukou fromGH-127330 (3.4) and@picnixz fromGH-131618 (3.4.1)

hugovk pushed a commit that referenced this pull request

Aug 14, 2025

[3.14]gh-132339: Add support for OpenSSL 3.5 (GH-137720) (#137747)

d8f4d56

* Add OpenSSL 3.5.2 definitions to Modules/_ssl_data_35.h (moved from Modules/_ssl_data_34.h)* Demote OpenSSL 3.1 to "old", remove it from CI* Update all OpenSSL versions to latest patchlevel in CI config and multissltests defaults* Add OpenSSL 3.5.2 to CI configuration and multissltests default list* Fix a typo in the argument parser description of multissltests.py(cherry picked from commit7a703c8)

This comment was marked as off-topic.

Copy link

Member

encukou commentedAug 14, 2025

Thessl_data*.h is only used for error messages.

This comment was marked as off-topic.

Copy link

Member

serhiy-storchaka commentedAug 14, 2025

Reminder about backporting.@zware

Copy link

MemberAuthor

zware commentedAug 14, 2025

@serhiy-storchaka: Seenote above; I'm not certain how we want to handle this.

encukou mentioned this pull request

Aug 15, 2025

gh-127330: Update for OpenSSL 3.4#127331

Merged

Copy link

Member

encukou commentedAug 15, 2025

See#127331 (comment).

encukou removed the needs backport to 3.13bugs and security fixes label

Aug 15, 2025

Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request

Aug 19, 2025

pythongh-132339: Add support for OpenSSL 3.5 (pythonGH-137720)

b1e373f

* Add OpenSSL 3.5.2 definitions to Modules/_ssl_data_35.h (moved from Modules/_ssl_data_34.h)* Demote OpenSSL 3.1 to "old", remove it from CI* Update all OpenSSL versions to latest patchlevel in CI config and multissltests defaults* Add OpenSSL 3.5.2 to CI configuration and multissltests default list* Fix a typo in the argument parser description of multissltests.py

Edward-Knight mentioned this pull request

Aug 26, 2025

Build with OpenSSL 3.5astral-sh/python-build-standalone#775

Closed

kumaraditya303 pushed a commit to miss-islington/cpython that referenced this pull request

Sep 9, 2025

[3.14]pythongh-132339: Add support for OpenSSL 3.5 (pythonGH-137720) (…

a53eaeb

…python#137747)* Add OpenSSL 3.5.2 definitions to Modules/_ssl_data_35.h (moved from Modules/_ssl_data_34.h)* Demote OpenSSL 3.1 to "old", remove it from CI* Update all OpenSSL versions to latest patchlevel in CI config and multissltests defaults* Add OpenSSL 3.5.2 to CI configuration and multissltests default list* Fix a typo in the argument parser description of multissltests.py(cherry picked from commit7a703c8)