Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.3k
[3.14] gh-137400: Fix a crash when disabling profiling across all threads (gh-137471)#137648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
…ads (pythongh-137471)The `PyEval_SetProfileAllThreads` function and other related functionshad a race condition on `tstate->c_profilefunc` that could lead to acrash when disable profiling or tracing on all threads while anotherthread is starting to profile or trace a a call.There are still potential crashes when threads exit concurrently withprofiling or tracing be enabled/disabled across all threads.(cherry picked from commit3626928)Co-authored-by: Sam Gross <colesbury@gmail.com>
From@pablogsal's comment in#137400 (comment):
|
Let's go with this smaller fix for 3.14.0 RC2. Thanks! |
4ebd928 intopython:3.14Uh oh!
There was an error while loading.Please reload this page.
…ll threads (pythongh-137471) (python#137648)Co-authored-by: Sam Gross <colesbury@gmail.com>
Uh oh!
There was an error while loading.Please reload this page.
The
PyEval_SetProfileAllThreadsfunction and other related functionshad a race condition on
tstate->c_profilefuncthat could lead to acrash when disable profiling or tracing on all threads while another
thread is starting to profile or trace a a call.
There are still potential crashes when threads exit concurrently with
profiling or tracing be enabled/disabled across all threads.
(cherry picked from commit3626928)
Co-authored-by: Sam Grosscolesbury@gmail.com
sys._setprofileallthreadsrace condition #137400