!buildbot ^((?!refleak).)* PR$

(You'll get failures due to the buildbots without any built-in hashes and with FIPS mode on)

The blurb was ok. We just don't document those methods because I think they are actually available simply asSSLSocket.send. Actually, I think they are wrongly documented (they are documented as methods of the module, not the class)

That's frustrating. I can't reproduce it emitting warnings locally, so I thoughtd45f6a8 fixed it.

Oh no, actually, recv() doesn't exist on SSLSockets. It's socket.socket.recv(). Same for send(). If you want you can do:

:meth:`SSLSocket.recv <socket.socket.recv>`

We'll deal with the blurb later, I avoided the reference altogether now. There's an actual test failure here:https://github.com/python/cpython/actions/runs/16849797228/job/47734333301

I think this is that stupid race condition. I'll look into fixingThreadedEchoServer or switching the test to something more robust.

There we go, that race is finally fixed. Let's try the buildbots again.

🤖 New build scheduled with the buildbot fleet by@ZeroIntensity for commit38e29f9 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F137588%2Fmerge

If you want to schedule another build, you need to add the🔨 test-with-buildbots label again.

Thanks@ZeroIntensity for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

Sorry,@ZeroIntensity, I could not cleanly backport this to3.14 due to a conflict.
Please backport usingcherry_picker on command line.

cherry_picker 55788a90967e82a9ea05b45c06a293b46ec53d72 3.14

Sorry,@ZeroIntensity, I could not cleanly backport this to3.13 due to a conflict.
Please backport usingcherry_picker on command line.

cherry_picker 55788a90967e82a9ea05b45c06a293b46ec53d72 3.13

GH-137613 is a backport of this pull request to the3.13 branch.

Is it just me or this hunk really doesn't apply cleanly on 3.13.6?

--- Modules/_ssl.c+++ Modules/_ssl.c@@ -2612,10 +2609,11 @@ _ssl__SSLSocket_sendfile_impl(PySSLSocket *self, int fd, Py_off_t offset,     }      do {-        PySSL_BEGIN_ALLOW_THREADS(self)+        Py_BEGIN_ALLOW_THREADS         retval = SSL_sendfile(self->ssl, fd, (off_t)offset, size, flags);         err = _PySSL_errno(retval < 0, self->ssl, (int)retval);-        PySSL_END_ALLOW_THREADS(self)+        Py_END_ALLOW_THREADS;+        _PySSL_FIX_ERRNO;         self->err = err;          if (PyErr_CheckSignals()) {

If I am not mistakenModules/_ssl.c doesn’t containSSL_sendfile call at all? Is there some other PR which is pre-requisite of this one on the top of the plain 3.13.6?

Oh, I see, so it is not this whole PR which would be a fix forgh-137583, onlythis one commit?

That was part of the conflict that prevented the automated backport. I had to manually remove that call so we had something that worked for 3.13. (To clarify,SSL_sendfile was added in 3.14.)

Reminder about backporting.@ZeroIntensity

Sorry, forgot to update here -- I manually pushed the fix from this PR to the original backport:#137107.

@python/organization-owners Could you block this user? TiA.