Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-131876: extract_hashlib helpers into a separate directory#137319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@picnixz
Copy link
Member

@picnixzpicnixz commentedAug 2, 2025•
edited
Loading

So this reverts the revert and fixes the WASM build. The WASI build was not affected but it should have been I think but I can't seem to make it fail (maybe duplicated symbols are allowed?)

@picnixzpicnixzforce-pushed thefeat/hashlib/static-library-131876 branch 2 times, most recently from259a802 toffe7db7CompareAugust 2, 2025 10:06
…python#136995)The `Modules/hashlib.h` helper file is now removed and split into multiple files:* `Modules/_hashlib/hashlib_buffer.h` -- Utilities for getting a buffer view and handling buffer inputs.* `Modules/_hashlib/hashlib_fetch.h` -- Utilities used when fetching a message digest from a digest-like identifier.  Currently, this file only contains common error messages as the fetching API is not yet implemented.* `Modules/_hashlib/hashlib_mutex.h` -- Utilities for managing the lock on cryptographic hash objects.
@picnixzpicnixzforce-pushed thefeat/hashlib/static-library-131876 branch fromffe7db7 to2fb8a6cCompareAugust 2, 2025 10:08
@picnixzpicnixz added the 🔨 test-with-buildbotsTest PR w/ buildbots; report in status section labelAug 2, 2025
@bedevere-bot

This comment was marked as resolved.

@bedevere-botbedevere-bot removed the 🔨 test-with-buildbotsTest PR w/ buildbots; report in status section labelAug 2, 2025
@picnixzpicnixz marked this pull request as ready for reviewAugust 2, 2025 16:52
@serhiy-storchaka
Copy link
Member

What is the point of splitting a header file into three?

@picnixz
Copy link
MemberAuthor

Maintainability for me. This will grow into more code when I plan to move some of the OpenSSL fetch interface from _hashopenssl there as I want to be able to use it in HMAC as well. However I had linker issues :( so for now I wanted to lay out the structure first.

What I can do is hold this change and design the fetch API. Then merge both of them at the same time.

@freakboy3742
Copy link
Contributor

!buildbot emscripten

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by@freakboy3742 for commit2fb8a6c 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F137319%2Fmerge

The command will test the builders whose names match following regular expression:emscripten

The builders matched are:

  • WASM Emscripten PR

@picnixz
Copy link
MemberAuthor

picnixz commentedSep 9, 2025•
edited
Loading

Huh so this also fails for EMscripten (or maybe it was another error). I'll just close this one, we don't really need to split it for now. I don't have time for the follow-up work now.

@picnixzpicnixz closed thisSep 9, 2025
@picnixzpicnixz deleted the feat/hashlib/static-library-131876 branchSeptember 9, 2025 09:51
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@gpsheadgpsheadAwaiting requested review from gpsheadgpshead is a code owner

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@picnixz@bedevere-bot@serhiy-storchaka@freakboy3742
[8]ページ先頭
©2009-2025 Movatter.jp