Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.3k
gh-137185: Fix_Py_DumpStack() async signal safety#137187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Call backtrace() once when installing the signal handler to ensure thatlibgcc is dynamically loaded outside the signal handler.This fixes a "signal-unsafe call inside of a signal" TSan error fromtest_faulthandler.test_enable_fd.
ZeroIntensity left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM
Uh oh!
There was an error while loading.Please reload this page.
11a8652 intopython:mainUh oh!
There was an error while loading.Please reload this page.
Thanks@colesbury for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14. |
…137187)Call backtrace() once when installing the signal handler to ensure thatlibgcc is dynamically loaded outside the signal handler.This fixes a "signal-unsafe call inside of a signal" TSan error fromtest_faulthandler.test_enable_fd.(cherry picked from commit11a8652)Co-authored-by: Sam Gross <colesbury@gmail.com>
GH-137206 is a backport of this pull request to the3.14 branch. |
…137187)Call backtrace() once when installing the signal handler to ensure thatlibgcc is dynamically loaded outside the signal handler.This fixes a "signal-unsafe call inside of a signal" TSan error fromtest_faulthandler.test_enable_fd.
… (gh-137206)Call backtrace() once when installing the signal handler to ensure thatlibgcc is dynamically loaded outside the signal handler.This fixes a "signal-unsafe call inside of a signal" TSan error fromtest_faulthandler.test_enable_fd.(cherry picked from commit11a8652)Co-authored-by: Sam Gross <colesbury@gmail.com>
Uh oh!
There was an error while loading.Please reload this page.
Call backtrace() once when installing the signal handler to ensure that libgcc is dynamically loaded outside the signal handler.
This fixes a "signal-unsafe call inside of a signal" TSan error from test_faulthandler.test_enable_fd.
_Py_DumpStack()is not signal-safe the first time it's called #137185