Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.3k
gh-137134: Update SQLite to 3.50.4 for binary releases#137135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
gh-137134: Update SQLite to 3.50.4 for binary releases#137135
Uh oh!
There was an error while loading.Please reload this page.
Conversation
gpshead commentedJul 27, 2025
I believe I pushed the SQLite 3.50.3 sources tohttps://github.com/python/cpython-source-deps/releases/tag/sqlite-3.50.3.0 properly. |
mhsmith commentedJul 28, 2025
I've added builds of this version tohttps://github.com/beeware/cpython-android-source-deps. |
mhsmith commentedJul 28, 2025
!buildbot android |
bedevere-bot commentedJul 28, 2025
🤖 New build scheduled with the buildbot fleet by@mhsmith for commitc69125d 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F137135%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
zware commentedJul 28, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Somehow the Oh, except that both branch from the |
gpshead commentedJul 29, 2025
I don't think this matters? at least not any more so than it not mattering the past few updates? All the sqlite- tags since that 3.45.3.0 one are in a similar state. Ithink this is due to people using a fork to push to initially? the commits "don't appear in this repository" which I think is GH for they're identified as being in a fork's repo? (GH repos are a unified hash namespace across all forks) A little confusing to me how github manages such a weird state of a tag in a repo who's commit claims not to be. in my own fork i probably re-pushed my branch after fixing the commit signing after getting that setup in order to follow the instructions that wanted a signed tag. (my tag was signed regardless) |
zware commentedJul 29, 2025
Right, the tag is an accurate representation of sqlite 3.50.3.0, the history is just messier than ideal (and I'm not sure when it started to go awry, or how). It's probably not worth trying to fix, but ideally we should try to straighten it out for the future next time around, or figure out some light automation. The GitHub "commit doesn't exist" message seems to be just that the commit is not in the history of any named branch in the repository; see for examplehttps://github.com/python/cpython/tree/2.7 where the |
zware left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Other than the trailing newline issue onMisc/externals.spdx.json that CI is complaining about (fixed bymake regen-sbom), LGTM.
Misc/NEWS.d/next/macOS/2025-07-27-02-17-40.gh-issue-137134.pjgITs.rst OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
bedevere-bot commentedAug 1, 2025
🤖 New build scheduled with the buildbot fleet by@gpshead for commit6232726 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F137135%2Fmerge If you want to schedule another build, you need to add the🔨 test-with-buildbots label again. |
ned-deily commentedAug 1, 2025
Note,SQLite 3.50.4 is now current. Also, thanks,@gpshead, for the code to handle more hash types in the macOS installer build. But I would prefer to separate that out as a separate PR not related to SQLite. I'll do that shortly and update this PR. |
🤖 Generated with [Claude Code](https://claude.ai/code)Co-Authored-By: Claude <noreply@anthropic.com>
Thanks@gpshead for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
Thanks@gpshead for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14. |
Sorry,@gpshead, I could not cleanly backport this to |
Sorry,@gpshead, I could not cleanly backport this to |
Sorry,@gpshead, I could not cleanly backport this to |
Sorry,@gpshead, I could not cleanly backport this to |
Sorry,@gpshead, I could not cleanly backport this to |
…H-137135)* Update SQLite to 3.50.3 for binary releases.* macOS and Windows news entries. what about Android?* update sbom hash* newline fix via regen-sbom* news wording* Update SQLite to 3.50.4 for binary releases.* update 3.50.4.0.tar.gz hash in sbom & regen-sbom to fix whitespace* Postpone to a separate PR the build-installer changes to support additional hash types(cherry picked from commit532c376)Co-authored-by: Gregory P. Smith <68491+gpshead@users.noreply.github.com>Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>Co-authored-by: Claude <noreply@anthropic.com>Co-authored-by: Ned Deily <nad@python.org>
gpshead commentedAug 5, 2025
(actually unsure ifany backport will automatically succeed given the sbom?) |
GH-137436 is a backport of this pull request to the3.14 branch. |
…H-137135)* Update SQLite to 3.50.3 for binary releases.* macOS and Windows news entries. what about Android?* update sbom hash* newline fix via regen-sbom* news wording* Update SQLite to 3.50.4 for binary releases.* update 3.50.4.0.tar.gz hash in sbom & regen-sbom to fix whitespace* Postpone to a separate PR the build-installer changes to support additional hash typesCo-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>Co-authored-by: Claude <noreply@anthropic.com>Co-authored-by: Ned Deily <nad@python.org>(cherry picked from commit532c376)
GH-137455 is a backport of this pull request to the3.13 branch. |
GH-137457 is a backport of this pull request to the3.11 branch. |
…ythonGH-137135)* Update SQLite to 3.50.3 for binary releases.* macOS and Windows news entries. what about Android?* update sbom hash* newline fix via regen-sbom* news wording* Update SQLite to 3.50.4 for binary releases.* update 3.50.4.0.tar.gz hash in sbom & regen-sbom to fix whitespace* Postpone to a separate PR the build-installer changes to support additional hash types(cherry picked from commit532c376)Co-authored-by: Gregory P. Smith <68491+gpshead@users.noreply.github.com>Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>Co-authored-by: Claude <noreply@anthropic.com>Co-authored-by: Ned Deily <nad@python.org>
GH-137458 is a backport of this pull request to the3.12 branch. |
GH-137459 is a backport of this pull request to the3.10 branch. |
GH-137462 is a backport of this pull request to the3.9 branch. |
hugovk commentedAug 6, 2025
Yeah, that and |
) (#137436)Co-authored-by: Gregory P. Smith <68491+gpshead@users.noreply.github.com>Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>Co-authored-by: Claude <noreply@anthropic.com>Co-authored-by: Ned Deily <nad@python.org>
) (#137455)gh-137134: Update SQLite to 3.50.4 for binary releases (GH-137135)* Update SQLite to 3.50.3 for binary releases.* macOS and Windows news entries. what about Android?* update sbom hash* newline fix via regen-sbom* news wording* Update SQLite to 3.50.4 for binary releases.* update 3.50.4.0.tar.gz hash in sbom & regen-sbom to fix whitespace* Postpone to a separate PR the build-installer changes to support additional hash types(cherry picked from commit532c376)Co-authored-by: Gregory P. Smith <68491+gpshead@users.noreply.github.com>Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>Co-authored-by: Claude <noreply@anthropic.com>Co-authored-by: Ned Deily <nad@python.org>
…H-137135)* Update SQLite to 3.50.3 for binary releases.* macOS and Windows news entries. what about Android?* update sbom hash* newline fix via regen-sbom* news wording* Update SQLite to 3.50.4 for binary releases.* update 3.50.4.0.tar.gz hash in sbom & regen-sbom to fix whitespace* Postpone to a separate PR the build-installer changes to support additional hash typesCo-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>Co-authored-by: Claude <noreply@anthropic.com>Co-authored-by: Ned Deily <nad@python.org>
…ythonGH-137135) (python#137436)Co-authored-by: Gregory P. Smith <68491+gpshead@users.noreply.github.com>Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>Co-authored-by: Claude <noreply@anthropic.com>Co-authored-by: Ned Deily <nad@python.org>
Uh oh!
There was an error while loading.Please reload this page.
Draft mode as this PR is probably only a start at the moment. I expect I've missed some bits and I think we need the macOS, Windows, and Android release builders to weigh in and confirm stuff works.
Two separate news entries per platform is odd, Android didn't get a news mention - we might want to rethink our categories for this kind of update? I was mirroring what I saw done for the 3.49.1 update.