Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

gh-137134: Update SQLite to 3.50.4 for binary releases#137135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@gpshead
Copy link
Member

@gpsheadgpshead commentedJul 27, 2025
edited by bedevere-appbot
Loading


Draft mode as this PR is probably only a start at the moment. I expect I've missed some bits and I think we need the macOS, Windows, and Android release builders to weigh in and confirm stuff works.

Two separate news entries per platform is odd, Android didn't get a news mention - we might want to rethink our categories for this kind of update? I was mirroring what I saw done for the 3.49.1 update.

@gpshead
Copy link
MemberAuthor

I believe I pushed the SQLite 3.50.3 sources tohttps://github.com/python/cpython-source-deps/releases/tag/sqlite-3.50.3.0 properly.

@mhsmith
Copy link
Member

I've added builds of this version tohttps://github.com/beeware/cpython-android-source-deps.

gpshead reacted with heart emoji

@mhsmith
Copy link
Member

!buildbot android

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by@mhsmith for commitc69125d 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F137135%2Fmerge

The command will test the builders whose names match following regular expression:android

The builders matched are:

  • aarch64 Android PR
  • AMD64 Android PR

@zware
Copy link
Member

zware commentedJul 28, 2025
edited
Loading

I believe I pushed the SQLite 3.50.3 sources tohttps://github.com/python/cpython-source-deps/releases/tag/sqlite-3.50.3.0 properly.

Somehow thesqlite branch head and thesqlite-3.50.3.0 tag refer to different commits that differ only inCommitDate. Other than that, either commit does the update correctly.

Oh, except that both branch from thesqlite-3.45.3.0 tag, not fromsqlite-3.49.1.0 :(

@gpshead
Copy link
MemberAuthor

except that both branch from the sqlite-3.45.3.0 tag, not from sqlite-3.49.1.0 :(

I don't think this matters? at least not any more so than it not mattering the past few updates? All the sqlite- tags since that 3.45.3.0 one are in a similar state. Ithink this is due to people using a fork to push to initially? the commits "don't appear in this repository" which I think is GH for they're identified as being in a fork's repo? (GH repos are a unified hash namespace across all forks) A little confusing to me how github manages such a weird state of a tag in a repo who's commit claims not to be.

in my own fork i probably re-pushed my branch after fixing the commit signing after getting that setup in order to follow the instructions that wanted a signed tag. (my tag was signed regardless)

@zware
Copy link
Member

Right, the tag is an accurate representation of sqlite 3.50.3.0, the history is just messier than ideal (and I'm not sure when it started to go awry, or how). It's probably not worth trying to fix, but ideally we should try to straighten it out for the future next time around, or figure out some light automation.

The GitHub "commit doesn't exist" message seems to be just that the commit is not in the history of any named branch in the repository; see for examplehttps://github.com/python/cpython/tree/2.7 where the2.7 tag replaced the2.7 branch.

gpshead reacted with thumbs up emoji

Copy link
Member

@zwarezware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Other than the trailing newline issue onMisc/externals.spdx.json that CI is complaining about (fixed bymake regen-sbom), LGTM.

@gpsheadgpshead marked this pull request as ready for reviewAugust 1, 2025 18:09
gpsheadand others added2 commitsAugust 1, 2025 18:12
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
@gpsheadgpshead added the 🔨 test-with-buildbotsTest PR w/ buildbots; report in status section labelAug 1, 2025
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by@gpshead for commit6232726 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F137135%2Fmerge

If you want to schedule another build, you need to add the🔨 test-with-buildbots label again.

@bedevere-botbedevere-bot removed the 🔨 test-with-buildbotsTest PR w/ buildbots; report in status section labelAug 1, 2025
@ned-deily
Copy link
Member

Note,SQLite 3.50.4 is now current.

Also, thanks,@gpshead, for the code to handle more hash types in the macOS installer build. But I would prefer to separate that out as a separate PR not related to SQLite. I'll do that shortly and update this PR.

gpshead reacted with thumbs up emoji

🤖 Generated with [Claude Code](https://claude.ai/code)Co-Authored-By: Claude <noreply@anthropic.com>
@gpsheadgpshead changed the titlegh-137134: Update SQLite to 3.50.3 for binary releasesgh-137134: Update SQLite to 3.50.4 for binary releasesAug 1, 2025
@miss-islington-app
Copy link

Thanks@gpshead for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington-app
Copy link

Thanks@gpshead for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry,@gpshead, I could not cleanly backport this to3.11 due to a conflict.
Please backport usingcherry_picker on command line.

cherry_picker 532c37695d03f84fc6d12f891d26b901ef402ac4 3.11

@miss-islington-app
Copy link

Sorry,@gpshead, I could not cleanly backport this to3.9 due to a conflict.
Please backport usingcherry_picker on command line.

cherry_picker 532c37695d03f84fc6d12f891d26b901ef402ac4 3.9

@miss-islington-app
Copy link

Sorry,@gpshead, I could not cleanly backport this to3.12 due to a conflict.
Please backport usingcherry_picker on command line.

cherry_picker 532c37695d03f84fc6d12f891d26b901ef402ac4 3.12

@miss-islington-app
Copy link

Sorry,@gpshead, I could not cleanly backport this to3.10 due to a conflict.
Please backport usingcherry_picker on command line.

cherry_picker 532c37695d03f84fc6d12f891d26b901ef402ac4 3.10

@miss-islington-app
Copy link

Sorry,@gpshead, I could not cleanly backport this to3.13 due to a conflict.
Please backport usingcherry_picker on command line.

cherry_picker 532c37695d03f84fc6d12f891d26b901ef402ac4 3.13

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestAug 5, 2025
…H-137135)* Update SQLite to 3.50.3 for binary releases.* macOS and Windows news entries. what about Android?* update sbom hash* newline fix via regen-sbom* news wording* Update SQLite to 3.50.4 for binary releases.* update 3.50.4.0.tar.gz hash in sbom & regen-sbom to fix whitespace* Postpone to a separate PR the build-installer changes to support additional hash types(cherry picked from commit532c376)Co-authored-by: Gregory P. Smith <68491+gpshead@users.noreply.github.com>Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>Co-authored-by: Claude <noreply@anthropic.com>Co-authored-by: Ned Deily <nad@python.org>
@gpshead
Copy link
MemberAuthor

(actually unsure ifany backport will automatically succeed given the sbom?)

zware reacted with thumbs up emoji

@bedevere-app
Copy link

GH-137436 is a backport of this pull request to the3.14 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.14bugs and security fixes labelAug 5, 2025
@gpsheadgpshead added the type-securityA security issue labelAug 5, 2025
hugovk pushed a commit to hugovk/cpython that referenced this pull requestAug 6, 2025
…H-137135)* Update SQLite to 3.50.3 for binary releases.* macOS and Windows news entries. what about Android?* update sbom hash* newline fix via regen-sbom* news wording* Update SQLite to 3.50.4 for binary releases.* update 3.50.4.0.tar.gz hash in sbom & regen-sbom to fix whitespace* Postpone to a separate PR the build-installer changes to support additional hash typesCo-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>Co-authored-by: Claude <noreply@anthropic.com>Co-authored-by: Ned Deily <nad@python.org>(cherry picked from commit532c376)
@bedevere-app
Copy link

GH-137455 is a backport of this pull request to the3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13bugs and security fixes labelAug 6, 2025
@bedevere-app
Copy link

GH-137457 is a backport of this pull request to the3.11 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.11only security fixes labelAug 6, 2025
hugovk pushed a commit to hugovk/cpython that referenced this pull requestAug 6, 2025
…ythonGH-137135)* Update SQLite to 3.50.3 for binary releases.* macOS and Windows news entries. what about Android?* update sbom hash* newline fix via regen-sbom* news wording* Update SQLite to 3.50.4 for binary releases.* update 3.50.4.0.tar.gz hash in sbom & regen-sbom to fix whitespace* Postpone to a separate PR the build-installer changes to support additional hash types(cherry picked from commit532c376)Co-authored-by: Gregory P. Smith <68491+gpshead@users.noreply.github.com>Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>Co-authored-by: Claude <noreply@anthropic.com>Co-authored-by: Ned Deily <nad@python.org>
@bedevere-app
Copy link

GH-137458 is a backport of this pull request to the3.12 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.12only security fixes labelAug 6, 2025
@bedevere-app
Copy link

GH-137459 is a backport of this pull request to the3.10 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.10only security fixes labelAug 6, 2025
@bedevere-app
Copy link

GH-137462 is a backport of this pull request to the3.9 branch.

@hugovk
Copy link
Member

(actually unsure ifany backport will automatically succeed given the sbom?)

Yeah, that andandroid.py, and also some of the older branches having 3.37 or 3.40 or 3.45, and this PR trying to change 3.49 to 3.50.

hugovk pushed a commit that referenced this pull requestAug 6, 2025
) (#137436)Co-authored-by: Gregory P. Smith <68491+gpshead@users.noreply.github.com>Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>Co-authored-by: Claude <noreply@anthropic.com>Co-authored-by: Ned Deily <nad@python.org>
Yhg1s pushed a commit that referenced this pull requestAug 6, 2025
) (#137455)gh-137134: Update SQLite to 3.50.4 for binary releases (GH-137135)* Update SQLite to 3.50.3 for binary releases.* macOS and Windows news entries. what about Android?* update sbom hash* newline fix via regen-sbom* news wording* Update SQLite to 3.50.4 for binary releases.* update 3.50.4.0.tar.gz hash in sbom & regen-sbom to fix whitespace* Postpone to a separate PR the build-installer changes to support additional hash types(cherry picked from commit532c376)Co-authored-by: Gregory P. Smith <68491+gpshead@users.noreply.github.com>Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>Co-authored-by: Claude <noreply@anthropic.com>Co-authored-by: Ned Deily <nad@python.org>
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull requestAug 19, 2025
…H-137135)* Update SQLite to 3.50.3 for binary releases.* macOS and Windows news entries. what about Android?* update sbom hash* newline fix via regen-sbom* news wording* Update SQLite to 3.50.4 for binary releases.* update 3.50.4.0.tar.gz hash in sbom & regen-sbom to fix whitespace* Postpone to a separate PR the build-installer changes to support additional hash typesCo-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>Co-authored-by: Claude <noreply@anthropic.com>Co-authored-by: Ned Deily <nad@python.org>
kumaraditya303 pushed a commit to miss-islington/cpython that referenced this pull requestSep 9, 2025
…ythonGH-137135) (python#137436)Co-authored-by: Gregory P. Smith <68491+gpshead@users.noreply.github.com>Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>Co-authored-by: Claude <noreply@anthropic.com>Co-authored-by: Ned Deily <nad@python.org>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@ned-deilyned-deilyned-deily approved these changes

@zwarezwarezware approved these changes

@erlend-aaslanderlend-aaslanderlend-aasland approved these changes

@sethmlarsonsethmlarsonAwaiting requested review from sethmlarsonsethmlarson is a code owner

@mhsmithmhsmithAwaiting requested review from mhsmithmhsmith is a code owner

@freakboy3742freakboy3742Awaiting requested review from freakboy3742freakboy3742 is a code owner

Assignees

No one assigned

Labels

type-securityA security issue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@gpshead@mhsmith@bedevere-bot@zware@ned-deily@hugovk@erlend-aasland

[8]ページ先頭

©2009-2025 Movatter.jp