Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.3k
GH-137059:url2pathname(): fix support for drive letter in netloc#137060
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
…tlocSupport file URLs like `file://c:/foo` in `urllib.request.url2pathname()`on Windows. This restores behaviour from 3.13.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM, but note that there is still a regression for//C:\\eggs#ham.
Uh oh!
There was an error while loading.Please reload this page.
10a925c intopython:mainUh oh!
There was an error while loading.Please reload this page.
Thanks@barneygale for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14. |
…tloc (pythonGH-137060)Support file URLs like `file://c:/foo` in `urllib.request.url2pathname()`on Windows. This restores behaviour from 3.13.(cherry picked from commit10a925c)Co-authored-by: Barney Gale <barney.gale@gmail.com>
GH-137144 is a backport of this pull request to the3.14 branch. |
…tloc (python#137060)Support file URLs like `file://c:/foo` in `urllib.request.url2pathname()`on Windows. This restores behaviour from 3.13.
…r in netloc (pythonGH-137060) (python#137144)Co-authored-by: Barney Gale <barney.gale@gmail.com>
Uh oh!
There was an error while loading.Please reload this page.
Support file URLs like
file://c:/fooinurllib.request.url2pathname()on Windows. This restores behaviour from 3.13.url2pathname()mishandles URL with Windows drive in netloc #137059