Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.4k
gh-124621: Emscripten: Add support for async input devices#136822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
+245 −1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
!buildbot emscripten |
bedevere-bot commentedJul 19, 2025
🤖 New build scheduled with the buildbot fleet by@hoodmane for commit3d573d5 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F136822%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
This is useful for implementing proper `input()`. It requires theJavaScript engine to support the wasm JSPI spec which is now stage 4.It is supported on Chrome since version 137 and on Firefox and nodebehind a flag.We override the `__wasi_fd_read()` syscall with our own variant thatchecks for a readAsync operation. If it has it, we use our own asyncvariant of `fd_read()`, otherwise we use the original `fd_read()`.We also add a variant of `FS.createDevice()` called`FS.createAsyncInputDevice()`.Finally, if JSPI is available, we wrap the `main()` symbol with`WebAssembly.promising()` so that we can stack switch from `fd_read()`.If JSPI is not available, attempting to read from an AsyncInputDevicewill raise an `OSError`.
3d573d5 to7d0e709Compare7ae4749 intopython:main 40 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Oops this caused some test failures. Fix incoming. |
hoodmane added a commit to hoodmane/cpython that referenced this pull requestJul 19, 2025
…handlingIntroduced inpythonGH-136822. If the fd is already closed,`SYSCALLS.getStreamFromFD()` throws an error. We need to catch it anddiscard it. The `__wasi_fd_read_orig()` fallback will use it to set errno.
hoodmane added a commit to hoodmane/cpython that referenced this pull requestJul 19, 2025
…handlingIntroduced inpythonGH-136822. If the fd is already closed,`SYSCALLS.getStreamFromFD()` throws an error. We need to catch it anddiscard it. The `__wasi_fd_read_orig()` fallback will use it to set errno.
hoodmane added a commit to hoodmane/cpython that referenced this pull requestJul 19, 2025
…handlingIntroduced inpythonGH-136822. If the fd is already closed,`SYSCALLS.getStreamFromFD()` throws an error. We need to catch it anddiscard it. The `__wasi_fd_read_orig()` fallback will use it to set errno.
hoodmane added a commit to hoodmane/cpython that referenced this pull requestJul 19, 2025
…handlingIntroduced inpythonGH-136822. If the fd is already closed,`SYSCALLS.getStreamFromFD()` throws an error. We need to catch it anddiscard it. The `__wasi_fd_read_orig()` fallback will use it to set errno.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
This is useful for implementing proper
input(). It requires the JavaScript engine to support the wasm JSPI spec which is now stage 4. It is supported on Chrome since version 137 and on Firefox and node behind a flag.We override the
__wasi_fd_read()syscall with our own variant that checks for a readAsync operation. If it has it, we use our own async variant offd_read(), otherwise we use the originalfd_read(). We also add a variant ofFS.createDevice()calledFS.createAsyncInputDevice().Finally, if JSPI is available, we wrap the
main()symbol withWebAssembly.promising()so that we can stack switch fromfd_read(). If JSPI is not available, attempting to read from an AsyncInputDevice will raise anOSError.