Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

GH-111758: Merge TSan and UBSan reusable GHA workflows#136820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
webknjaz wants to merge3 commits intopython:main
base:main
Choose a base branch
Loading
fromwebknjaz:maintenance/111758-gha-combined-san

Conversation

webknjaz
Copy link
Contributor

@webknjazwebknjaz commentedJul 19, 2025
edited by bedevere-appbot
Loading

This patch deduplicates the contents ofreusable-tsan.yml andreusable-ubsan.yml, making them one. The new workflow replaces the duplicated ones in the top-levelbuild.yml and are called with different sanitizer parameters.

It is based on Hugo's patch. Context:

echo "CC=clang" >> "$GITHUB_ENV"
else
echo "UBSAN_OPTIONS=log_path=${GITHUB_WORKSPACE}/san_log" >> "$GITHUB_ENV"
echo "CC=clang -fno-sanitize-recover=all" >> "$GITHUB_ENV"
Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Why is-fno-sanitize-recover=all needed?

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Per discussion w/ Hugo, this was a temporary change that didn't make it into the original PR and so is no longer needed.

Suggested change
echo "CC=clang -fno-sanitize-recover=all" >> "$GITHUB_ENV"
echo "CC=clang" >> "$GITHUB_ENV"

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Note

Prior to this PR, this workflow wasn't contributing to the branch protection status. Once it's merged, it'll fail the PRs if something crashes.

with:
sanitizer:TSan
config_hash:${{ needs.build-context.outputs.config-hash }}
free-threading:${{ matrix.free-threading }}

build-ubsan:
name:Undefined behavior sanitizer
Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Per discussion w/ Hugo, I'm going to put this under the same group as TSAN.

build-tsan-reusable:
name:'Threadsanitizer'
build-san-reusable:
name:${{ inputs.sanitizer }}
Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Per discussion w/ Hugo, this needs to mention the FT flag.

--with-pydebug
${{ fromJSON(inputs.free-threading) && '--disable-gil' || '' }}
-name:Build CPython
run:make -j4
-name:Display build info
run:make pythoninfo
-name:Tests
run:./python -m test --tsan -j4
run:./python -m test${{ inputs.sanitizer == 'TSan' && '--tsan' || '' }} -j4
-name:Parallel tests
if:fromJSON(inputs.free-threading)
Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This should probably be guarded by tsan too:

Suggested change
if:fromJSON(inputs.free-threading)
if:>-
inputs.sanitizer == 'TSan'
&& fromJSON(inputs.free-threading)

@webknjazwebknjazforce-pushed themaintenance/111758-gha-combined-san branch from39b8215 to8592567CompareJuly 19, 2025 16:01
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@ezio-melottiezio-melottiAwaiting requested review from ezio-melottiezio-melotti will be requested when the pull request is marked ready for reviewezio-melotti is a code owner

@hugovkhugovkAwaiting requested review from hugovkhugovk will be requested when the pull request is marked ready for reviewhugovk is a code owner

@AA-TurnerAA-TurnerAwaiting requested review from AA-TurnerAA-Turner will be requested when the pull request is marked ready for reviewAA-Turner is a code owner

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@webknjaz@StanFromIreland@encukou@hugovk

[8]ページ先頭

©2009-2025 Movatter.jp