Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.4k
GH-111758: Merge TSan and UBSan reusable GHA workflows#136820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Conversation
Uh oh!
There was an error while loading.Please reload this page.
.github/workflows/reusable-san.yml Outdated
echo "CC=clang" >> "$GITHUB_ENV" | ||
else | ||
echo "UBSAN_OPTIONS=log_path=${GITHUB_WORKSPACE}/san_log" >> "$GITHUB_ENV" | ||
echo "CC=clang -fno-sanitize-recover=all" >> "$GITHUB_ENV" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Why is-fno-sanitize-recover=all
needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Per discussion w/ Hugo, this was a temporary change that didn't make it into the original PR and so is no longer needed.
echo "CC=clang -fno-sanitize-recover=all" >> "$GITHUB_ENV" | |
echo "CC=clang" >> "$GITHUB_ENV" |
.github/workflows/reusable-ubsan.yml Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Note
Prior to this PR, this workflow wasn't contributing to the branch protection status. Once it's merged, it'll fail the PRs if something crashes.
with: | ||
sanitizer:TSan | ||
config_hash:${{ needs.build-context.outputs.config-hash }} | ||
free-threading:${{ matrix.free-threading }} | ||
build-ubsan: | ||
name:Undefined behavior sanitizer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Per discussion w/ Hugo, I'm going to put this under the same group as TSAN.
build-tsan-reusable: | ||
name:'Threadsanitizer' | ||
build-san-reusable: | ||
name:${{ inputs.sanitizer }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Per discussion w/ Hugo, this needs to mention the FT flag.
.github/workflows/reusable-san.yml Outdated
--with-pydebug | ||
${{ fromJSON(inputs.free-threading) && '--disable-gil' || '' }} | ||
-name:Build CPython | ||
run:make -j4 | ||
-name:Display build info | ||
run:make pythoninfo | ||
-name:Tests | ||
run:./python -m test --tsan -j4 | ||
run:./python -m test${{ inputs.sanitizer == 'TSan' && '--tsan' || '' }} -j4 | ||
-name:Parallel tests | ||
if:fromJSON(inputs.free-threading) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This should probably be guarded by tsan too:
if:fromJSON(inputs.free-threading) | |
if:>- | |
inputs.sanitizer == 'TSan' | |
&& fromJSON(inputs.free-threading) |
39b8215
to8592567
Compare
Uh oh!
There was an error while loading.Please reload this page.
This patch deduplicates the contents of
reusable-tsan.yml
andreusable-ubsan.yml
, making them one. The new workflow replaces the duplicated ones in the top-levelbuild.yml
and are called with different sanitizer parameters.It is based on Hugo's patch. Context: