Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

gh-131724: Add a new max_response_headers param to HTTP/HTTPSConnection#136814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
aeurielesn wants to merge4 commits intopython:main
base:main
Choose a base branch
Loading
fromaeurielesn:gh-131724

Conversation

aeurielesn
Copy link

@aeurielesnaeurielesn commentedJul 19, 2025
edited
Loading

@python-cla-bot
Copy link

python-cla-botbot commentedJul 19, 2025
edited
Loading

All commit authors signed the Contributor License Agreement.

CLA signed

@bedevere-app
Copy link

Most changes to Pythonrequire a NEWS entry. Add one using theblurb_it web app or theblurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply theskip news label instead.

Comment on lines 884 to 885
ifmax_headersisNone:
max_headers=_MAXHEADERS
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Please keep it asNone if unset

aeurielesn and ilovelinux reacted with thumbs up emoji
@@ -1426,7 +1433,7 @@ def getresponse(self):

try:
try:
response.begin()
response.begin(_max_headers=self.max_headers)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Please don't pass the argument if it's not set.

aeurielesn reacted with thumbs up emoji
@@ -864,7 +868,7 @@ def _get_content_length(body, method):
returnNone

def__init__(self,host,port=None,timeout=socket._GLOBAL_DEFAULT_TIMEOUT,
source_address=None,blocksize=8192):
source_address=None,blocksize=8192,max_headers=None):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Maybe name itmax_response_headers

aeurielesn and ilovelinux reacted with thumbs up emoji
@bedevere-app
Copy link

Most changes to Pythonrequire a NEWS entry. Add one using theblurb_it web app or theblurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply theskip news label instead.

@bedevere-app
Copy link

Most changes to Pythonrequire a NEWS entry. Add one using theblurb_it web app or theblurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply theskip news label instead.

@aeurielesnaeurielesn changed the titlegh-131724: Add a new max_headers param to HTTP/HTTPSConnectiongh-131724: Add a new max_response_headers param to HTTP/HTTPSConnectionJul 19, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@encukouencukouencukou left review comments

Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@aeurielesn@encukou

[8]ページ先頭

©2009-2025 Movatter.jp