Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.4k
gh-131724: Add a new max_response_headers param to HTTP/HTTPSConnection#136814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Conversation
python-cla-botbot commentedJul 19, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Most changes to Pythonrequire a NEWS entry. Add one using theblurb_it web app or theblurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
Lib/http/client.py Outdated
ifmax_headersisNone: | ||
max_headers=_MAXHEADERS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Please keep it asNone
if unset
Lib/http/client.py Outdated
@@ -1426,7 +1433,7 @@ def getresponse(self): | |||
try: | |||
try: | |||
response.begin() | |||
response.begin(_max_headers=self.max_headers) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Please don't pass the argument if it's not set.
Lib/http/client.py Outdated
@@ -864,7 +868,7 @@ def _get_content_length(body, method): | |||
returnNone | |||
def__init__(self,host,port=None,timeout=socket._GLOBAL_DEFAULT_TIMEOUT, | |||
source_address=None,blocksize=8192): | |||
source_address=None,blocksize=8192,max_headers=None): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Maybe name itmax_response_headers
Most changes to Pythonrequire a NEWS entry. Add one using theblurb_it web app or theblurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
Most changes to Pythonrequire a NEWS entry. Add one using theblurb_it web app or theblurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
Uh oh!
There was an error while loading.Please reload this page.