Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.3k
bpo-36999: Add asyncio.Task.get_coro()#13680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Doc/library/asyncio-task.rst Outdated
| ..method::get_coro() | ||
| Return the coroutine object that was passed to the constructor. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I dislike mentioningconstructor here.
Above we have the text:
Use the high-level :func:`asyncio.create_task` function to create Tasks, or the low-level :meth:`loop.create_task` or :func:`ensure_future` functions. Manual instantiation of Tasks is discouraged.Maybe rephrase this line toReturn the coroutine object that was used for the task creation. or something like this?
Sorry, I'm not a native speaker. Don't insist on the exact wording but you've got my idea.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I'd just say this: "Return the coroutine object wrapped by the Task".
Doc/library/asyncio-task.rst Outdated
| ..method::get_coro() | ||
| Return the coroutine object that was passed to the constructor. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
| Return the coroutine objectthat was passed totheconstructor. | |
| Return the coroutine objectwrapped bythe:class:`Task`. |
@1st1 like this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Yeah, I think it's great. If you have time just merge Alex's PR and we can fix this ourselves. Up to you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I changed the wording now as requested.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Great!
Thanks! |
Uh oh!
There was an error while loading.Please reload this page.
https://bugs.python.org/issue36999