Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.4k
[3.14] Doc/c-api/memory.rst: extend --without-pymalloc doc with ASan information (GH-136790)#136798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
miss-islington wants to merge1 commit intopython:3.14Choose a base branch frommiss-islington:backport-d19bb44-3.14
base:3.14
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
+7 −0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
…tion (pythonGH-136790)* Doc/c-api/memory.rst: extend --without-pymalloc doc with ASan informationThis commit extends the documentation for disabling pymalloc with the `--without-pymalloc` flag regarding why it is worth to use it when enabling AddressSanitizer for Python build (which is done, e.g., in CPython's CI builds).I have tested the CPython latest main build with both ASan and pymalloc enabled and it seems to work just fine. I did run the `python -m test` suite which didn't uncover any ASan crashes (though, it detected some memory leaks, which I believe are irrelevant here).I have discussed ASan and this flag with@encukou on the CPython Core sprint on EuroPython 2025. We initially thought that the `--without-pymalloc` flag is needed for ASan builds due to the fact pymalloc must hit the begining of page when determining if the memory to be freed comes from pymalloc or was allocated by the system malloc. In other words, we thought, that ASan would crash CPython during free of big objects (allocated by system malloc). It may be that this was the case in the past, but it is not the case anymore as the `address_in_range` function used by pymalloc is annotated to be skipped from the ASan instrumentation.This code can be seen here:https://github.com/python/cpython/blob/acefb978dcb5dd554e3c49a3015ee5c2ad6bfda1/Objects/obmalloc.c#L2096-L2110While the annotation macro is defined here:https://github.com/python/cpython/blob/acefb978dcb5dd554e3c49a3015ee5c2ad6bfda1/Include/pyport.h#L582-L598And the corresponding attribute is documented in:* for gcc:https://gcc.gnu.org/onlinedocs/gcc/Common-Function-Attributes.html#index-no_005fsanitize_005faddress-function-attribute* for clang:https://clang.llvm.org/docs/AttributeReference.html#no-sanitize-address-no-address-safety-analysis* Update Doc/c-api/memory.rst* Improve --with-address-sanitizer and pymalloc docs---------(cherry picked from commitd19bb44)Co-authored-by: Disconnect3d <dominik.b.czarnota@gmail.com>Co-authored-by: Petr Viktorin <encukou@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
This commit extends the documentation for disabling pymalloc with the
--without-pymalloc
flag regarding why it is worth to use it when enabling AddressSanitizer for Python build (which is done, e.g., in CPython's CI builds).I have tested the CPython latest main build with both ASan and pymalloc enabled and it seems to work just fine. I did run the
python -m test
suite which didn't uncover any ASan crashes (though, it detected some memory leaks, which I believe are irrelevant here).I have discussed ASan and this flag with@encukou on the CPython Core sprint on EuroPython 2025. We initially thought that the
--without-pymalloc
flag is needed for ASan builds due to the fact pymalloc must hit the begining of page when determining if the memory to be freed comes from pymalloc or was allocated by the system malloc. In other words, we thought, that ASan would crash CPython during free of big objects (allocated by system malloc). It may be that this was the case in the past, but it is not the case anymore as theaddress_in_range
function used by pymalloc is annotated to be skipped from the ASan instrumentation.This code can be seen here:
cpython/Objects/obmalloc.c
Lines 2096 to 2110 inacefb97
While the annotation macro is defined here:
cpython/Include/pyport.h
Lines 582 to 598 inacefb97
And the corresponding attribute is documented in:
for gcc:https://gcc.gnu.org/onlinedocs/gcc/Common-Function-Attributes.html#index-no_005fsanitize_005faddress-function-attribute
for clang:https://clang.llvm.org/docs/AttributeReference.html#no-sanitize-address-no-address-safety-analysis
Update Doc/c-api/memory.rst
Improve --with-address-sanitizer and pymalloc docs
(cherry picked from commitd19bb44)
Co-authored-by: Disconnect3ddominik.b.czarnota@gmail.com
Co-authored-by: Petr Viktorinencukou@gmail.com
📚 Documentation preview 📚:https://cpython-previews--136798.org.readthedocs.build/