Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-136752: Clarify documentation forIPv{N}Address.is_reserved#136794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
AA-Turner merged 17 commits intopython:mainfrommlnrt:fix-doc-issue-136752
Jul 19, 2025

Conversation

mlnrt
Copy link
Contributor

@mlnrtmlnrt commentedJul 19, 2025•
edited
Loading

This PR proposes a documentation improvement to clarify the conditions for theipaddressis_reserved property to returnTrue

📚 Documentation preview 📚:https://cpython-previews--136794.org.readthedocs.build/

@python-cla-bot
Copy link

python-cla-botbot commentedJul 19, 2025•
edited
Loading

All commit authors signed the Contributor License Agreement.

CLA signed

@Dobatymo
Copy link
Contributor

Maybe you should specifially mention, thatis_reserved does not correspond to theReserved-by-Protocol column in the_iana-ipv4-special-registry source... only to thename.

@mlnrt
Copy link
ContributorAuthor

Will do

Dobatymo reacted with thumbs up emoji

Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
@AA-TurnerAA-Turner changed the titlegh-136752: clarify ipaddress documentation of the is_reserved propertygh-136752: Clarify documentation forIPv{N}Address.is_reserved`Jul 19, 2025
@AA-TurnerAA-Turner added needs backport to 3.13bugs and security fixes needs backport to 3.14bugs and security fixes labelsJul 19, 2025
Copy link
Member

@AA-TurnerAA-Turner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks!

A

@AA-TurnerAA-Turnerenabled auto-merge (squash)July 19, 2025 14:38
@AA-TurnerAA-Turner changed the titlegh-136752: Clarify documentation forIPv{N}Address.is_reserved`gh-136752: Clarify documentation forIPv{N}Address.is_reservedJul 19, 2025
@AA-TurnerAA-Turnerdisabled auto-mergeJuly 19, 2025 14:40
@AA-TurnerAA-Turnerenabled auto-merge (squash)July 19, 2025 14:40
@AA-TurnerAA-Turner merged commit6293d8a intopython:mainJul 19, 2025
30 checks passed
@github-project-automationgithub-project-automationbot moved this fromTodo toDone inDocs PRsJul 19, 2025
@miss-islington-app
Copy link

Thanks@mlnrt for the PR, and@AA-Turner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestJul 19, 2025
…d`` (pythonGH-136794)(cherry picked from commit6293d8a)Co-authored-by: Matthieu Lienart <50069805+mlnrt@users.noreply.github.com>Co-authored-by: Matthieu Lienart <matthieu.lienart@axians.com>Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestJul 19, 2025
…d`` (pythonGH-136794)(cherry picked from commit6293d8a)Co-authored-by: Matthieu Lienart <50069805+mlnrt@users.noreply.github.com>Co-authored-by: Matthieu Lienart <matthieu.lienart@axians.com>Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
@bedevere-app
Copy link

GH-136827 is a backport of this pull request to the3.14 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.14bugs and security fixes labelJul 19, 2025
@bedevere-app
Copy link

GH-136828 is a backport of this pull request to the3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13bugs and security fixes labelJul 19, 2025
AA-Turner added a commit that referenced this pull requestJul 19, 2025
…ed`` (GH-136794) (#136827)gh-136752: Clarify documentation for ``IPv{N}Address.is_reserved`` (GH-136794)(cherry picked from commit6293d8a)Co-authored-by: Matthieu Lienart <50069805+mlnrt@users.noreply.github.com>Co-authored-by: Matthieu Lienart <matthieu.lienart@axians.com>Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
AA-Turner added a commit that referenced this pull requestJul 19, 2025
…ed`` (GH-136794) (#136828)gh-136752: Clarify documentation for ``IPv{N}Address.is_reserved`` (GH-136794)(cherry picked from commit6293d8a)Co-authored-by: Matthieu Lienart <50069805+mlnrt@users.noreply.github.com>Co-authored-by: Matthieu Lienart <matthieu.lienart@axians.com>Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@AA-TurnerAA-TurnerAA-Turner approved these changes

Assignees
No one assigned
Labels
docsDocumentation in the Doc dirskip newssprint
Projects
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@mlnrt@Dobatymo@AA-Turner
[8]ページ先頭
©2009-2025 Movatter.jp