Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-136438: Make suretest_remote_pdb pass with all optimization levels#136788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
olp-cs wants to merge3 commits intopython:main
base:main
Choose a base branch
Loading
fromolp-cs:gh-136438-fix-OO

Conversation

olp-cs
Copy link

@olp-csolp-cs commentedJul 19, 2025•
edited
Loading

Related to#136438

  • New test cases for the scenario when no help is available.
  • Skip test cases not relevant for the current optimization level.

Details

Help is not available for the optimization level -OO.

please do not run Python with -OO if you need command help

(pdb.py, lines 2439-2440)

Testing

With -OO

./python -OO -m test test_remote_pdb -v

test_handling_help_when_available (test.test_remote_pdb.PdbClientTestCase.test_handling_help_when_available) ... skipped 'Help not available for -OO'test_handling_help_when_not_available (test.test_remote_pdb.PdbClientTestCase.test_handling_help_when_not_available) ... ok

Without -OO

./python -m test test_remote_pdb -v

test_handling_help_when_available (test.test_remote_pdb.PdbClientTestCase.test_handling_help_when_available)Test handling help requests when help is available. ... oktest_handling_help_when_not_available (test.test_remote_pdb.PdbClientTestCase.test_handling_help_when_not_available)Test handling help requests when help is not available. ... skipped 'Needs -OO'

AtEuroPython Sprints with@encukou

@python-cla-bot
Copy link

python-cla-botbot commentedJul 19, 2025•
edited
Loading

All commit authors signed the Contributor License Agreement.

CLA signed

@bedevere-appbedevere-appbot added awaiting review testsTests in the Lib/test dir labelsJul 19, 2025
@bedevere-app
Copy link

Most changes to Pythonrequire a NEWS entry. Add one using theblurb_it web app or theblurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply theskip news label instead.

Copy link
Member

@encukouencukou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you! Let's merge this :)

Please don't update the branch; GitHub has a prominent button fo that but all it does here is restart the test run.

olp-cs reacted with thumbs up emoji
Copy link
Member

@ZeroIntensityZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

@ZeroIntensity
Copy link
Member

Oh, oops, you beat me to it.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@encukouencukouencukou approved these changes

@ZeroIntensityZeroIntensityZeroIntensity approved these changes

@gaogaotiantiangaogaotiantianAwaiting requested review from gaogaotiantiangaogaotiantian is a code owner

Assignees
No one assigned
Labels
awaiting mergeskip newstestsTests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@olp-cs@ZeroIntensity@encukou@StanFromIreland
[8]ページ先頭
©2009-2025 Movatter.jp