Movatterモバイル変換

Skip to content

python/cpythonPublic

NotificationsYou must be signed in to change notification settings
Fork32.4k
Star67.9k

gh-116738: Make syslog module thread-safe#136760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open

yoney wants to merge2 commits intopython:main

base:main

Choose a base branch

fromyoney:ft_syslog

Open

gh-116738: Make syslog module thread-safe#136760

yoney wants to merge2 commits intopython:mainfromyoney:ft_syslog

Conversation

yoney

Copy link

Contributor

yoney commentedJul 18, 2025•
edited
Loading

Make thesetlogmask() function in thesyslog module thread-safe. These changes are relevant for scenarios where the GIL is disabled or when using subinterpreters.

The functionssyslog(),openlog(), andcloselog() in the syslog module are already handled for FT-Python using the@critical_section on themodule. However, there might be an issue withsyslog() for subinterpreters on macOS.

cpython/Modules/syslogmodule.c

Lines 242 to 245 in03017a8

	#ifdef__APPLE__
	// gh-98178: On macOS, libc syslog() is not thread-safe
	syslog(priority,"%s",message);
	#else

I will check/test the macOS subinterpreter and create a separate PR if necessary.

Linux man page (3):setlogmast()

cc:@mpage @colesbury

Issue:Audit all built-in modules for thread safety #116738

@yoney

pythongh-116738: Make syslog module thread-safe

d2f43bd

@bedevere-app

bedevere-appbot mentioned this pull request

Audit all built-in modules for thread safety#116738

Open

@yoney

yoney marked this pull request as ready for review

July 18, 2025 17:07

@bedevere-app

bedevere-appbot added the awaiting review label

@mpage

mpage requested review fromcolesbury,Yhg1s andmpage

July 18, 2025 19:10

mpage

mpage approved these changes

View reviewed changes

Copy link

Contributor

mpage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM!

Lib/test/test_free_threading/test_syslog.py OutdatedShow resolvedHide resolved

@bedevere-app

bedevere-appbot added awaiting merge and removed awaiting review labels

@yoney

pythongh-116738: Wrap with try/finally

b8102af

@ZeroIntensity

ZeroIntensity added the topic-free-threading label

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Labels

awaiting merge topic-free-threading

3 participants

@yoney

@mpage

@ZeroIntensity

[8]ページ先頭

©2009-2025 Movatter.jp