Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

gh-136744: Remove unnecessary chmod from pydoc.apropos() test.#136746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
freakboy3742 wants to merge1 commit intopython:main
base:main
Choose a base branch
Loading
fromfreakboy3742:remove-unneeded-chmod

Conversation

freakboy3742
Copy link
Contributor

@freakboy3742freakboy3742 commentedJul 17, 2025
edited
Loading

The test added as part of fixing#65747 includes a chmod call that appears to be unrelated to the problem that was reported.

Part of the triage of that issue included the observation that the problem could be reproduced by removing execute permissions from a directory. However, this appears to be unrelated to the reported problem.

By removing the execute permission from the directory, the module is converted into a namespace package - at which point, itcan't have a docstring. However, you can also validate empty docstring handling by... having a module without a docstring. Which is what the test implements.

Adding to the confusion - the test only removesuser execute permissions. Group and Global execute permissions are retained. The original report removedall execute permissions, not just user execute permissions; so the test isn't reproducing the triage example. The only explanation I can think of for this is that the buildbots run with a umask of 0o77, which means removing user execute permissionsis effectively equivalent tochmod a-x... but it won't be for anyone who isn't running under buildbot.

This PR removes the chmod call, which also allows for removing the workaround for Emscripten.

Thanks to@hoodmane for help diagnosing what was going on here.

@freakboy3742
Copy link
ContributorAuthor

!buildbot emscripten

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by@freakboy3742 for commit15b6a15 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F136746%2Fmerge

The command will test the builders whose names match following regular expression:emscripten

The builders matched are:

  • WASM Emscripten PR

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
awaiting core reviewneeds backport to 3.14bugs and security fixesskip newstestsTests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@freakboy3742@bedevere-bot

[8]ページ先頭

©2009-2025 Movatter.jp