Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.4k
gh-136234: Fix _SelectorSocketTransport.writelines to be robust to connection loss#136743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Conversation
The following commit authors need to sign the Contributor License Agreement: |
I've previously signed the CLA on behalf of my organisation, but my work email address has changed since then (same employer though). Is there a process to reuse that form, or do I need to sign a new one? Alternatively, I can rewrite my commits to use that old email address (it still works, just deprecated). |
You need to sign again with the new email. |
| @@ -1048,6 +1048,11 @@ def _read_ready__on_eof(self): | |||
| else: | |||
| self.close() | |||
| def _write_after_conn_lost(self): | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This is only used at two places, I would prefer this to be inlined rather than as a new function.
Uh oh!
There was an error while loading.Please reload this page.
Closes#136234