Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.7k
gh-136234: Fix _SelectorSocketTransport.writelines to be robust to connection loss#136743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
python-cla-botbot commentedJul 17, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
bmerry commentedJul 17, 2025
I've previously signed the CLA on behalf of my organisation, but my work email address has changed since then (same employer though). Is there a process to reuse that form, or do I need to sign a new one? Alternatively, I can rewrite my commits to use that old email address (it still works, just deprecated). |
kumaraditya303 commentedJul 17, 2025
You need to sign again with the new email. |
Uh oh!
There was an error while loading.Please reload this page.
bmerry commentedJul 21, 2025
Ok, will do. Might take a few days to run it past my employer. |
bmerry commentedJul 28, 2025
@kumaraditya303 thanks for reviewing. The CLA has had to go to our IP people (even though I've previously signed it with a different email address), so there may be a delay. I'm hoping not longer than a week or two. |
kumaraditya303 commentedJul 28, 2025
Okay, ping me when the CLA is done and I'll merge it, thanks! |
bmerry commentedAug 8, 2025
@kumaraditya303 I've filled in the form (had to use the Adobe eSign process since it's on behalf of an organisation). So it's now just waiting for the PSF to process it. I don't know if I get a notification when that's complete, but if I do I'll ping you again. |
bmerry commentedAug 25, 2025
@kumaraditya303 any idea how long it's supposed to take for a CLA signed on behalf of an organisation to be processed? I submitted the form more than 2 weeks ago and haven't seen anything about it since. |
kumaraditya303 commentedAug 26, 2025
You need to sign the CLA with the new email as well independent of organization signing. |
bmerry commentedAug 26, 2025
The form says "If you wish to sign a Contributor Agreement on behalf of an organization or to use a different Initial License, please use the manual form instead" (note theinstead). Presumably it must be possible to not do the automatic form since that only caters to one of the possible initial licenses. I'll follow up with the PSF to check what's happening. |
bmerry commentedSep 8, 2025
@kumaraditya303 I've had no reply from the PSF, so for expediency I've signed the CLA as an individual so that the CLAbot will be happy. This contribution is made on behalf of my employer, for which I've completed the manual form. |
7d435cf intopython:mainUh oh!
There was an error while loading.Please reload this page.
Thanks@bmerry for the PR, and@kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
…t to connection loss (pythonGH-136743)(cherry picked from commit7d435cf)Co-authored-by: Bruce Merry <1963944+bmerry@users.noreply.github.com>
…t to connection loss (pythonGH-136743)(cherry picked from commit7d435cf)Co-authored-by: Bruce Merry <1963944+bmerry@users.noreply.github.com>
GH-138673 is a backport of this pull request to the3.14 branch. |
GH-138674 is a backport of this pull request to the3.13 branch. |
bmerry commentedSep 8, 2025
Are there any security grounds for a 3.12 backport? If an attacker can figure out how to win this race condition, they could potentially DoS a server that is not expecting an AttributeError. I guess typically that would just crash the asyncio Task that's handling the connection and the server would survive. |
…t to connection loss (pythonGH-136743)(cherry picked from commit7d435cf)Co-authored-by: Bruce Merry <1963944+bmerry@users.noreply.github.com>
…t to connection loss (python#136743)
GH-138702 is a backport of this pull request to the3.14 branch. |
1 similar comment
GH-138702 is a backport of this pull request to the3.14 branch. |
…t to connection loss (python#136743)
…e robust to connection loss (pythonGH-136743) (pythonGH-138702)(cherry picked from commit5cd6cfe)Co-authored-by: Kumar Aditya <kumaraditya@python.org>
Uh oh!
There was an error while loading.Please reload this page.
Closes#136234