Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.4k
gh-127146: Emscripten: Set umask to zero in test_apropos_empty_doc#136740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation
We think this will fix `test_apropos_empty_doc`.
!buildbot emscripten |
bedevere-bot commentedJul 17, 2025
🤖 New build scheduled with the buildbot fleet by@hoodmane for commit595781e 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F136740%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
hoodmane commentedJul 17, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
So the test passes with a umask of 077 on native Python but fails with a umask of 077 in Emscripten Python. I will try to understand why. |
!buildbot emscripten |
bedevere-bot commentedJul 17, 2025
🤖 New build scheduled with the buildbot fleet by@hoodmane for commit643e889 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F136740%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
22af5d3 intopython:mainUh oh!
There was an error while loading.Please reload this page.
Thanks@hoodmane for the PR, and@freakboy3742 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14. |
…-136740)Clears the umask used during a test of pydoc.apropos when testing onEmscripten. This is to work around a known issue in Emscripten; but it's notclear if the chmod call that is causing the problem is actually testinganything of significance.(cherry picked from commit 22af5d35a620ee44393853036a8450ceb047688e)Co-authored-by: Hood Chatham <roberthoodchatham@gmail.com>
GH-136745 is a backport of this pull request to the3.14 branch. |
…) (#136745)Clears the umask used during a test of pydoc.apropos when testing onEmscripten. This is to work around a known issue in Emscripten; but it's notclear if the chmod call that is causing the problem is actually testinganything of significance.(cherry picked from commit22af5d3)Co-authored-by: Hood Chatham <roberthoodchatham@gmail.com>
Uh oh!
There was an error while loading.Please reload this page.
This fixes
test_apropos_empty_doc. Much thanks to@freakboy3742 for the investigation.