Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-136681: make argsbuf static to speedup processing positional arguments with AC#136732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
skirpichev wants to merge1 commit intopython:main
base:main
Choose a base branch
Loading
fromskirpichev:ac-argsbuf/136681

Conversation

skirpichev
Copy link
Contributor

@skirpichevskirpichev commentedJul 17, 2025•
edited by bedevere-appbot
Loading

@skirpichev
Copy link
ContributorAuthor

benchmark:#136681 (comment)

@ZeroIntensity
Copy link
Member

Won't this break when called concurrently?

@skirpichev
Copy link
ContributorAuthor

Won't this break when called concurrently?

Yes, apparently it does :-( Probably, this can't be fixed easily.

Alternative approach should work:#136681 (comment). The_PyArg_UnpackKeywords() is implemented as a macro (which encodes fast-path) and a function. So, the if condition should keep negation of the fast-path condition in the macro (which can be removed).

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@lysnikolaoulysnikolaouAwaiting requested review from lysnikolaoulysnikolaou will be requested when the pull request is marked ready for reviewlysnikolaou is a code owner

@erlend-aaslanderlend-aaslandAwaiting requested review from erlend-aaslanderlend-aasland will be requested when the pull request is marked ready for reviewerlend-aasland is a code owner

@corona10corona10Awaiting requested review from corona10corona10 will be requested when the pull request is marked ready for reviewcorona10 is a code owner

@ethanfurmanethanfurmanAwaiting requested review from ethanfurmanethanfurman will be requested when the pull request is marked ready for reviewethanfurman is a code owner

@rhettingerrhettingerAwaiting requested review from rhettingerrhettinger will be requested when the pull request is marked ready for reviewrhettinger is a code owner

@berkerpeksagberkerpeksagAwaiting requested review from berkerpeksagberkerpeksag will be requested when the pull request is marked ready for reviewberkerpeksag is a code owner

@gpsheadgpsheadAwaiting requested review from gpsheadgpshead will be requested when the pull request is marked ready for reviewgpshead is a code owner

@pgansslepganssleAwaiting requested review from pgansslepganssle will be requested when the pull request is marked ready for reviewpganssle is a code owner

@abalkinabalkinAwaiting requested review from abalkinabalkin will be requested when the pull request is marked ready for reviewabalkin is a code owner

@ericsnowcurrentlyericsnowcurrentlyAwaiting requested review from ericsnowcurrentlyericsnowcurrently will be requested when the pull request is marked ready for reviewericsnowcurrently is a code owner

@brettcannonbrettcannonAwaiting requested review from brettcannonbrettcannon will be requested when the pull request is marked ready for reviewbrettcannon is a code owner

@ncoghlanncoghlanAwaiting requested review from ncoghlanncoghlan will be requested when the pull request is marked ready for reviewncoghlan is a code owner

@warsawwarsawAwaiting requested review from warsawwarsaw will be requested when the pull request is marked ready for reviewwarsaw is a code owner

@picnixzpicnixzAwaiting requested review from picnixzpicnixz will be requested when the pull request is marked ready for reviewpicnixz is a code owner

@1st11st1Awaiting requested review from 1st11st1 will be requested when the pull request is marked ready for review1st1 is a code owner

@asvetlovasvetlovAwaiting requested review from asvetlovasvetlov will be requested when the pull request is marked ready for reviewasvetlov is a code owner

@kumaraditya303kumaraditya303Awaiting requested review from kumaraditya303kumaraditya303 will be requested when the pull request is marked ready for reviewkumaraditya303 is a code owner

@willingcwillingcAwaiting requested review from willingcwillingc will be requested when the pull request is marked ready for reviewwillingc is a code owner

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@skirpichev@ZeroIntensity
[8]ページ先頭
©2009-2025 Movatter.jp