Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.4k
gh-127146: Emscripten: more regular stack overflow skips#136708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
gh-127146: Emscripten: more regular stack overflow skips#136708
Uh oh!
There was an error while loading.Please reload this page.
Conversation
…ad of ad hoc skipIn two places. Also, make the skip_emscripten_stack_overflow messagematch wasi's message.
!buildbot Emscripten |
bedevere-bot commentedJul 16, 2025
🤖 New build scheduled with the buildbot fleet by@hoodmane for commit8642a6c 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F136708%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
👍
c730952 intopython:mainUh oh!
There was an error while loading.Please reload this page.
Thanks@hoodmane for the PR, and@freakboy3742 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14. |
…nGH-136708)Makes the Emscripten stack overflow skip message consistent with WASI,and replaces some ad-hoc skips.(cherry picked from commit c730952aa64b790c75c437cb63a1242dc08c2e97)Co-authored-by: Hood Chatham <roberthoodchatham@gmail.com>
GH-136712 is a backport of this pull request to the3.14 branch. |
Uh oh!
There was an error while loading.Please reload this page.
In two places use skip_emscripten_stack_overflow instead of skipIf with an ad-hoc message. Also, make the skip_emscripten_stack_overflow message match wasi's message.