Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.4k
gh-116738: Make pwd module thread-safe#136695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation
Note: I am not sure if there is a CI setup where |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looks great! I'll wait to merge for a day or two to give other folks a chance to look.
eddc8c0
intopython:mainUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Make the
pwd
module functionsgetpwuid()
,getpwnam()
, andgetpwall()
thread-safe. These changes apply to scenarios where the GIL is disabled or in subinterpreter use cases.Py_LIMITED_API
to usePyMutex
, necessary for both FT-Python and subinterpreter use cases, similar to changes in the grp module (gh-126316: Make grp.getgrall() thread-safe: add a mutex #127055).cc:@mpage@colesbury@Yhg1s