Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-136669: build_asyncio as static module#136670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
kumaraditya303 merged 8 commits intopython:mainfromkumaraditya303:asyncio-perf
Jul 16, 2025

Conversation

kumaraditya303
Copy link
Contributor

@kumaraditya303kumaraditya303 commentedJul 15, 2025•
edited by bedevere-appbot
Loading

Copy link
Member

@AA-TurnerAA-Turner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I think it would be better to keep_asyncio inSetup.stdlib.in, it isn't really in the same category asboostrap.in. You could instead add the*static* directive in a new section at the end of the file, see e.g. the current*shared* directive on line 187. Would this work?

A

@kumaraditya303
Copy link
ContributorAuthor

I think it would be better to keep _asyncio in Setup.stdlib.in, it isn't really in the same category as boostrap.in. You could instead add thestatic directive in a new section at the end of the file, see e.g. the currentshared directive on line 187. Would this work?

Yes, that worked, I have changed it now. Thanks

@kumaraditya303kumaraditya303 marked this pull request as ready for reviewJuly 15, 2025 16:38
@kumaraditya303kumaraditya303 added the 🔨 test-with-buildbotsTest PR w/ buildbots; report in status section labelJul 15, 2025
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by@kumaraditya303 for commit87ff8fc 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F136670%2Fmerge

If you want to schedule another build, you need to add the🔨 test-with-buildbots label again.

@bedevere-botbedevere-bot removed the 🔨 test-with-buildbotsTest PR w/ buildbots; report in status section labelJul 15, 2025
@kumaraditya303
Copy link
ContributorAuthor

Looks like there is some network issue on ubuntu bots.

@kumaraditya303
Copy link
ContributorAuthor

The CI is fixed now and tested locally on macOS:

❯sudo ./python.exe -mtest test_external_inspection -v== CPython 3.15.0a0 (heads/asyncio-perf:424b6568065, Jul 16 2025, 16:43:27) [Clang 17.0.0 (clang-1700.0.13.5)]== macOS-15.5-arm64-arm-64bit-Mach-O little-endian== Python build: debug== cwd: /Users/kumaraditya/work/cpython/build/test_python_worker_92525æ== CPU count: 10== encodings: locale=UTF-8 FS=utf-8== resources: all test resources are disabled, use -u option to unskip testsUsing random seed: 15797115460:00:00 load avg: 8.90 Run 1 test sequentially in a single process0:00:00 load avg: 8.90 [1/1] test_external_inspectiontest_async_gather_remote_stack_trace (test.test_external_inspection.TestGetStackTrace.test_async_gather_remote_stack_trace) ... oktest_async_global_awaited_by (test.test_external_inspection.TestGetStackTrace.test_async_global_awaited_by) ... oktest_async_remote_stack_trace (test.test_external_inspection.TestGetStackTrace.test_async_remote_stack_trace) ... oktest_async_staggered_race_remote_stack_trace (test.test_external_inspection.TestGetStackTrace.test_async_staggered_race_remote_stack_trace) ... oktest_asyncgen_remote_stack_trace (test.test_external_inspection.TestGetStackTrace.test_asyncgen_remote_stack_trace) ... oktest_only_active_thread (test.test_external_inspection.TestGetStackTrace.test_only_active_thread) ... oktest_remote_stack_trace (test.test_external_inspection.TestGetStackTrace.test_remote_stack_trace) ... oktest_self_trace (test.test_external_inspection.TestGetStackTrace.test_self_trace) ... oktest_unsupported_platform_error (test.test_external_inspection.TestUnsupportedPlatformHandling.test_unsupported_platform_error) ... skipped 'Test only runs on unsupported platforms (not Linux, macOS, or Windows)'----------------------------------------------------------------------Ran 9 tests in 0.546sOK (skipped=1)0:00:00 load avg: 8.90 [1/1] test_external_inspection passed== Tests result: SUCCESS ==1 test OK.Total duration: 594 msTotal tests: run=9 skipped=1Total test files: run=1/1Result: SUCCESS

@kumaraditya303kumaraditya303 linked an issueJul 16, 2025 that may beclosed by this pull request
@kumaraditya303kumaraditya303 merged commitb7d7225 intopython:mainJul 16, 2025
92 of 113 checks passed
@kumaraditya303kumaraditya303 deleted the asyncio-perf branchJuly 16, 2025 16:39
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@AA-TurnerAA-TurnerAA-Turner left review comments

@pablogsalpablogsalpablogsal approved these changes

@ambvambvAwaiting requested review from ambvambv is a code owner

@1st11st1Awaiting requested review from 1st11st1 is a code owner

@erlend-aaslanderlend-aaslandAwaiting requested review from erlend-aaslanderlend-aasland is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

build_asyncio module as static module
4 participants
@kumaraditya303@bedevere-bot@AA-Turner@pablogsal
[8]ページ先頭
©2009-2025 Movatter.jp