NotificationsYou must be signed in to change notification settings
Fork32.4k
Star67.9k

Fix a minor indentation error#136661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

gaogaotiantian merged 2 commits intopython:mainfromgaogaotiantian:fix-indentation-error

Jul 15, 2025

Merged

Fix a minor indentation error#136661

gaogaotiantian merged 2 commits intopython:mainfromgaogaotiantian:fix-indentation-error

Jul 15, 2025

Conversation

Copy link

Member

gaogaotiantian commentedJul 14, 2025

Not sure if this counts as a "cosmetic change" but this did confuse me for a few seconds. I believe this is a typo when Mark check in the code.

Fix a minor indentation error

4c12263

gaogaotiantian requested review fromiritkatriel andmarkshannon

July 14, 2025 21:21

gaogaotiantian added skip issue skip news labels

Jul 14, 2025

bedevere-appbot added the awaiting core review label

Jul 14, 2025

iritkatriel approved these changes

Jul 14, 2025

View reviewed changes

bedevere-appbot added awaiting merge and removed awaiting core review labels

Jul 14, 2025

Merge branch 'main' into fix-indentation-error

3ad2552

gaogaotiantian merged commitdb20324 intopython:main

Jul 15, 2025

40 checks passed

bedevere-appbot removed the awaiting merge label

Jul 15, 2025

Copy link

bedevere-bot commentedJul 15, 2025

⚠️⚠️⚠️ Buildbot failure⚠️⚠️⚠️

Hi! The buildbotAMD64 Debian root 3.x (tier-1) has failed when building commitdb20324.

What do you need to do:

Don't panic.
Checkthe buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/345/builds/11815) and take a look at the build logs.
Check if the failure is related to this commit (db20324) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/345/builds/11815

Failed tests:

test_math

Failed subtests:

test_sumprod_stress - test.test_math.MathTests.test_sumprod_stress
test_eq_with_mutation - test.test_set.TestBinaryOpsMutating_Set_Set.test_eq_with_mutation

Summary of the results of the build (if available):

Click to see traceback logs

Traceback (most recent call last):  File"/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/test_math.py", line1571, intest_sumprod_stress    run(baseline_sumprod,*args),~~~^^^^^^^^^^^^^^^^^^^^^^^^^  File"/root/buildarea/3.x.angelico-debian-amd64/build/Lib/unittest/case.py", line723, in__call__returnself.run(*args,**kwds)~~~~~~~~^^^^^^^^^^^^^^^TypeError:TestCase.run() takes from 1 to 2 positional arguments but 4 were givenTraceback (most recent call last):  File"/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/test_set.py", line1908, intest_eq_with_mutationself.check_set_op_does_not_crash(lambdaa,b: a== b)~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^  File"/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/test_set.py", line1897, incheck_set_op_does_not_crash    set1, set2=self.make_sets_of_bad_objects()~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^  File"/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/test_set.py", line1890, inmake_sets_of_bad_objects    set2=self.constructor2(Bad()for _inrange(randrange(50)))  File"/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/test_set.py", line1886, in__hash__return randrange(2)  File"/root/buildarea/3.x.angelico-debian-amd64/build/Lib/random.py", line312, inrandrangeraiseValueError("empty range for randrange()")ValueError:empty range for randrange()