NotificationsYou must be signed in to change notification settings
Fork32.4k
Star67.9k

[3.14] gh-127146: Emscripten: Fix test_open_undecodable_uri by setting`-sTEXTDECODER=2` (GH-136624)#136631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

freakboy3742 merged 1 commit intopython:3.14frommiss-islington:backport-283b050-3.14

Jul 14, 2025

Merged

[3.14] gh-127146: Emscripten: Fix test_open_undecodable_uri by setting`-sTEXTDECODER=2` (GH-136624)#136631

freakboy3742 merged 1 commit intopython:3.14frommiss-islington:backport-283b050-3.14

Jul 14, 2025

Conversation

Copy link

Contributor

miss-islington commentedJul 13, 2025•
edited by bedevere-appbot
Loading

Removes the JS text decoder fallback and gets rid of the bugs due to the differences
in behavior on invalid utf8 strings. Seeemscripten-core/emscripten#24690.
(cherry picked from commit283b050)

Co-authored-by: Hood Chathamroberthoodchatham@gmail.com

Issue:Emscripten: Get test suite passing #127146

pythongh-127146: Emscripten: Fix test_open_undecodable_uri by setting…

e660f71

… `-sTEXTDECODER=2` (pythonGH-136624)Removes the JS text decoder fallback and gets rid of the bugs due to the differencesin behavior on invalid utf8 strings. Seeemscripten-core/emscripten#24690.(cherry picked from commit283b050)Co-authored-by: Hood Chatham <roberthoodchatham@gmail.com>