Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.4k
gh-127146: Emscripten: Fix test_open_undecodable_uri by setting-sTEXTDECODER=2#136624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
gh-127146: Emscripten: Fix test_open_undecodable_uri by setting-sTEXTDECODER=2#136624
Uh oh!
There was an error while loading.Please reload this page.
Conversation
…DER=2`This removes the JS text decoder fallback and gets rid of the bugsdue to the differences in behavior on invalid utf8 strings.Seeemscripten-core/emscripten#24690.
-sTEXTDECODER=2-sTEXTDECODER=2!buildbot emscripten |
bedevere-bot commentedJul 13, 2025
🤖 New build scheduled with the buildbot fleet by@hoodmane for commit358e0a3 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F136624%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
freakboy3742 left a comment• edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looks like it resolves the test failures in CI, so I'll call that a win
(EDIT: There are still other failures, but this patch results inless failures, and specifically no failure with the sqlite3 tests.)
283b050 intopython:mainUh oh!
There was an error while loading.Please reload this page.
Thanks@hoodmane for the PR, and@freakboy3742 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14. |
… `-sTEXTDECODER=2` (pythonGH-136624)Removes the JS text decoder fallback and gets rid of the bugs due to the differencesin behavior on invalid utf8 strings. Seeemscripten-core/emscripten#24690.(cherry picked from commit283b050)Co-authored-by: Hood Chatham <roberthoodchatham@gmail.com>
GH-136631 is a backport of this pull request to the3.14 branch. |
…g `-sTEXTDECODER=2` (GH-136624) (#136631)Removes the JS text decoder fallback and gets rid of the bugs due to the differencesin behavior on invalid utf8 strings. Seeemscripten-core/emscripten#24690.(cherry picked from commit283b050)Co-authored-by: Hood Chatham <roberthoodchatham@gmail.com>
…nymoreThis might have been fixed bypythongh-136624, or by some Emscripten change.In any case, it no longer seems to be needed.
This makes the code smaller and gets rid of a buggy code path. Weswitched to this upstream to fix a test: seepython/cpython#136624.
…nymore (pythonGH-136707)This might have been fixed bypythongh-136624, or by some Emscripten change.In any case, it no longer seems to be needed.(cherry picked from commitdcd27aa)Co-authored-by: Hood Chatham <roberthoodchatham@gmail.com>
Uh oh!
There was an error while loading.Please reload this page.
This removes the JS text decoder fallback and gets rid of the bugs due to the differences in behavior on invalid utf8 strings. Seeemscripten-core/emscripten#24690.