Now tests pass with all combinations of -OO and --without-doc-strings.
It was long lists of errors before, but all proposed fixes are just to add some neededoptimize=False options.

Issue:Multiple tests fail with-OO #136438

Fix test_ast to work with -OO

1806585

efimov-mikhail requested review fromEclips4 andtomasr8 ascode owners

July 12, 2025 17:43

bedevere-appbot added the awaiting review label

Jul 12, 2025

bedevere-appbot mentioned this pull request

Jul 12, 2025

Multiple tests fail with-OO#136438

Open

8 tasks

bedevere-appbot added the testsTests in the Lib/test dir label

Jul 12, 2025

Fix test_ast to work with -OO 2

738b82d

brianschubert added the skip news label

Jul 12, 2025

StanFromIreland requested a review fromsobolevn

July 12, 2025 21:34

Eclips4 reviewed

Jul 17, 2025

View reviewed changes

Lib/test/test_ast/test_ast.py OutdatedShow resolvedHide resolved

Copy link

Member

Eclips4 commentedJul 17, 2025

I believe the explanation is as follows:
If theoptimize parameter isn’t passed explicitly, the interpreter uses its internal setting (which can be modified using the -O or-OO flags).
Am I right,@efimov-mikhail?

Update Lib/test/test_ast/test_ast.py

3d75f06

Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru>

Copy link

ContributorAuthor

efimov-mikhail commentedJul 17, 2025•
edited
Loading

If theoptimize parameter isn’t passed explicitly, the interpreter uses its internal setting (which can be modified using the -O or-OO flags).

Exactly. I've added checks only in those tests that fail with-OO. We now force to runast.parse andcompile without optimizations to be sure that their results don't depend on runtime flags.