Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-136438: Make suretest_generated_cases pass with all optimization levels#136594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
efimov-mikhail wants to merge1 commit intopython:main
base:main
Choose a base branch
Loading
fromefimov-mikhail:issue-136438-test_generated_cases

Conversation

efimov-mikhail
Copy link
Contributor

@efimov-mikhailefimov-mikhail commentedJul 12, 2025•
edited by bedevere-appbot
Loading

Now tests pass with all combinations of -OO and --without-doc-strings.

Before:

======================================================================FAIL: test_missing_override_failure (test.test_generated_cases.TestGeneratedAbstractCases.test_missing_override_failure)----------------------------------------------------------------------AssertionError: 'case OP: {\n            JitOptRef out;\n [104 chars]   }' != ''- case OP: {-             JitOptRef out;-             out = sym_new_not_null(ctx);-             stack_pointer[-1] = out;-             break;-         }During handling of the above exception, another exception occurred:Traceback (most recent call last):  File "/home/sikko/projects/cpython/Lib/test/test_generated_cases.py", line 2040, in test_missing_override_failure    with self.assertRaisesRegex(AssertionError, "All abstract uops"):         ~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^AssertionError: "All abstract uops" does not match "'case OP: {\n            JitOptRef out;\n [104 chars]   }' != ''- case OP: {-             JitOptRef out;-             out = sym_new_not_null(ctx);-             stack_pointer[-1] = out;-             break;-         }"

@bedevere-appbedevere-appbot mentioned this pull requestJul 12, 2025
8 tasks
@efimov-mikhailefimov-mikhail changed the titlegh-136438: Make sure test_generated_cases pass with all optimization levelsgh-136438: Make suretest_generated_cases pass with all optimization levelsJul 12, 2025
@efimov-mikhail
Copy link
ContributorAuthor

Cc@Eclips4

@Eclips4Eclips4 self-requested a reviewJuly 19, 2025 09:18
abstract_uop_nameinbase_uop_names
),f"All abstract uops should override base uops, but{abstract_uop_name} is not."
ifabstract_uop_namenotinbase_uop_names:
raiseAssertionError(f"All abstract uops should override base uops, "
Copy link
Member

@Eclips4Eclips4Jul 19, 2025•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Though I'm not sure, from an architectural point of view, that raisingAssertionError manually is appropriate. I think we should change it toValueError and handle it in the tests. WDYM?

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@Eclips4Eclips4Eclips4 left review comments

@markshannonmarkshannonAwaiting requested review from markshannonmarkshannon is a code owner

@sobolevnsobolevnAwaiting requested review from sobolevn

Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@efimov-mikhail@Eclips4@StanFromIreland
[8]ページ先頭
©2009-2025 Movatter.jp