Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-136549: Fix signature of threading.excepthook()#136559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchakaserhiy-storchaka commentedJul 11, 2025•
edited by bedevere-appbot
Loading

@ZeroIntensity
Copy link
Member

Is there any reason this wasn't caught by regrtest?

@serhiy-storchaka
Copy link
MemberAuthor

Regrtest sets differentthreading.excepthook.

Copy link
Member

@ZeroIntensityZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Ok, thanks. The core change looks good to me. Could we add a simple test for this? Something likeinspect.signature(threading.__excepthook__) should work.

serhiy-storchaka reacted with thumbs up emoji
Copy link
Member

@ZeroIntensityZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

@serhiy-storchakaserhiy-storchaka merged commitbe2c3d2 intopython:mainJul 12, 2025
45 checks passed
@miss-islington-app
Copy link

Thanks@serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestJul 12, 2025
…6559)(cherry picked from commitbe2c3d2)Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-app
Copy link

GH-136589 is a backport of this pull request to the3.14 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.14bugs and security fixes labelJul 12, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestJul 12, 2025
…6559)(cherry picked from commitbe2c3d2)Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-app
Copy link

GH-136590 is a backport of this pull request to the3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13bugs and security fixes labelJul 12, 2025
@serhiy-storchakaserhiy-storchaka deleted the threading-excepthook-signature branchJuly 12, 2025 15:54
serhiy-storchaka added a commit that referenced this pull requestJul 12, 2025
…GH-136590)(cherry picked from commitbe2c3d2)Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka added a commit that referenced this pull requestJul 12, 2025
…GH-136589)(cherry picked from commitbe2c3d2)Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
picnixz pushed a commit to picnixz/cpython that referenced this pull requestJul 13, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@ZeroIntensityZeroIntensityZeroIntensity approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@serhiy-storchaka@ZeroIntensity
[8]ページ先頭
©2009-2025 Movatter.jp