Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-136492: AddFrameLocalsProxyType totypes#136546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
ZeroIntensity wants to merge27 commits intopython:main
base:main
Choose a base branch
Loading
fromZeroIntensity:frameslocalsproxy-types

Conversation

ZeroIntensity
Copy link
Member

@ZeroIntensityZeroIntensity commentedJul 11, 2025•
edited
Loading

bswck reacted with thumbs up emoji
@ZeroIntensity
Copy link
MemberAuthor

Ugh, those test failures look like an existing bug onFrameLocalsProxy.

blockchainGuru1018 reacted with thumbs up emoji

blockchainGuru1018

This comment was marked as spam.

@picnixz
Copy link
Member

@python/organization-owners Could you blockblockchainGuru1018 for spam & misguided reviews? TiA.

JacobCoffee reacted with thumbs up emoji

@gaogaotiantian
Copy link
Member

Ugh, those test failures look like an existing bug on FrameLocalsProxy.

Could you be more specific? Maybe raise an issue for that so I can fix it later?

@ZeroIntensity
Copy link
MemberAuthor

Could you be more specific? Maybe raise an issue for that so I can fix it later?

There were a few things I had to skip intest_inspect. Ithink they're bugs, but I haven't investigated the test enough to be sure.

@gaogaotiantian
Copy link
Member

Okay now we need some typing expert to review this.@JelleZijlstra maybe?

@ZeroIntensity
Copy link
MemberAuthor

I'd also appreciate it if@AA-Turner could take a look; he's done some recent work withtypes and_types.

AA-Turner reacted with thumbs up emoji

@JelleZijlstra
Copy link
Member

You don't really need a static typing expert for thetypes module; it predates static typing and is useful even without static typing. The PR seems pretty straightforward to me.

ZeroIntensity reacted with thumbs up emoji

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
@@ -58,6 +58,7 @@ def test_names(self):
'MethodDescriptorType', 'MethodType', 'MethodWrapperType',
'ModuleType', 'NoneType', 'NotImplementedType', 'SimpleNamespace',
'TracebackType', 'UnionType', 'WrapperDescriptorType',
'FrameLocalsProxyType'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Please keep the list sorted (GH doesn't let me add a suggestion)

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I had that originally but@picnixz had reservations about it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I think it's better to keep the list sorted rather than attempt to minimise 3-4 lines of diff here.

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Fixed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

My suggestion was to keep it sorted but by just adding the export on its own line.

AA-Turner reacted with thumbs up emoji
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
@AA-TurnerAA-Turner changed the titlegh-136492: AddFrameLocalsProxy totypesgh-136492: AddFrameLocalsProxyType totypesJul 15, 2025
ZeroIntensityand others added6 commitsJuly 15, 2025 04:40
Should I test before I push my changes? Yes. Will I ever do it? No.
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@JelleZijlstraJelleZijlstraJelleZijlstra left review comments

@AA-TurnerAA-TurnerAA-Turner left review comments

@picnixzpicnixzpicnixz left review comments

@gaogaotiantiangaogaotiantiangaogaotiantian left review comments

@blockchainGuru1018blockchainGuru1018blockchainGuru1018 approved these changes

@markshannonmarkshannonAwaiting requested review from markshannonmarkshannon is a code owner

Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

6 participants
@ZeroIntensity@picnixz@gaogaotiantian@JelleZijlstra@AA-Turner@blockchainGuru1018
[8]ページ先頭
©2009-2025 Movatter.jp