Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-136523: fix wave.Wave_write emitting an unraisable when open raises#136529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
serhiy-storchaka merged 7 commits intopython:mainfrominventshah:fix-gh-136523
Jul 13, 2025

Conversation

inventshah
Copy link
Contributor

@inventshahinventshah commentedJul 11, 2025•
edited by bedevere-appbot
Loading

Fixes#136523, by movingbuiltins.open inside thetry-except block and always callinginitfp (which does not raise) forWave_write.

@python-cla-bot
Copy link

python-cla-botbot commentedJul 11, 2025•
edited
Loading

All commit authors signed the Contributor License Agreement.

CLA signed

@bedevere-app
Copy link

Most changes to Pythonrequire a NEWS entry. Add one using theblurb_it web app or theblurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply theskip news label instead.

@inventshahinventshah changed the titlegh-136523: fix Wave_write.__del__ raise after attempt to open protected filegh-136523: fix wave.Wave_write emitting an unraisable when open raisesJul 12, 2025
Copy link
Member

@serhiy-storchakaserhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM. 👍

Thank you for your contribution,@inventshah.

@serhiy-storchakaserhiy-storchaka added needs backport to 3.13bugs and security fixes needs backport to 3.14bugs and security fixes labelsJul 13, 2025
@serhiy-storchakaserhiy-storchaka merged commit171de05 intopython:mainJul 13, 2025
49 checks passed
@miss-islington-app
Copy link

Thanks@inventshah for the PR, and@serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestJul 13, 2025
… raises (pythonGH-136529)(cherry picked from commit171de05)Co-authored-by: Sachin Shah <39803835+inventshah@users.noreply.github.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestJul 13, 2025
… raises (pythonGH-136529)(cherry picked from commit171de05)Co-authored-by: Sachin Shah <39803835+inventshah@users.noreply.github.com>
@bedevere-app
Copy link

GH-136606 is a backport of this pull request to the3.14 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.14bugs and security fixes labelJul 13, 2025
@bedevere-app
Copy link

GH-136607 is a backport of this pull request to the3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13bugs and security fixes labelJul 13, 2025
serhiy-storchaka pushed a commit that referenced this pull requestJul 13, 2025
…n raises (GH-136529) (GH-136607)(cherry picked from commit171de05)Co-authored-by: Sachin Shah <39803835+inventshah@users.noreply.github.com>
@inventshahinventshah deleted the fix-gh-136523 branchJuly 13, 2025 06:56
picnixz pushed a commit to picnixz/cpython that referenced this pull requestJul 13, 2025
serhiy-storchaka pushed a commit that referenced this pull requestJul 16, 2025
…n raises (GH-136529) (GH-136606)(cherry picked from commit171de05)Co-authored-by: Sachin Shah <39803835+inventshah@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@ZeroIntensityZeroIntensityZeroIntensity left review comments

@LamentXU123LamentXU123LamentXU123 left review comments

@serhiy-storchakaserhiy-storchakaserhiy-storchaka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Exception raised fromWave_write.__del__() after failed attempt to open file for write operation
4 participants
@inventshah@serhiy-storchaka@ZeroIntensity@LamentXU123
[8]ページ先頭
©2009-2025 Movatter.jp