Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

GH-135904: Improve the JIT's performance on macOS#136528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
brandtbucher merged 8 commits intopython:mainfrombrandtbucher:jit-targets
Jul 14, 2025

Conversation

brandtbucher
Copy link
Member

@brandtbucherbrandtbucher commentedJul 11, 2025
edited by bedevere-appbot
Loading

This PR makes a couple of minor tweaks to the JIT that result in 1.7% faster performance on macOS overall:

  • Our AArch64code doesn't need to be 8-byte aligned, just thedata. Currently, we guarantee this by aligning all code anyways, since the data follows immediately after it. This is wasteful, since it means about half of all stencils end in anop. Instead, don't pad any stencils, and just align the data when it's compiled. 🤦🏼
  • The textual assembly "optimizer" pass has a bug where it interprets lines that are commented with; as instructions. By recognizing these commented lines, we can remove more zero-length jumps at the end of stencils. 🤦🏼
  • During this same pass, we can represent the address of the next instruction (the end of the template, or the_JIT_CONTINUE label) as a "local" label, which allows the assembler to resolve it at compile time and encode it more efficiently. There's a special (platform-dependent) prefix to signal this.
  • Finally, instead of declaring jump targets (_JIT_CONTINUE,_JIT_ERROR_TARGET, and_JIT_JUMP_TARGET) asextern symbols, just declare them as local functions. This results in more efficient jumps (and also allows us to remove a somewhat hacky pre-processing step for the textual assembly on Windows to force these efficient jumps).

Fidget-Spinner, Genarito, and Sacul0457 reacted with rocket emoji
@Fidget-Spinner
Copy link
Member

This is amazing! I can't review it, but thanks for all your assembler wizardry on this.

brandtbucher reacted with heart emoji

Copy link
Contributor

@diegorussodiegorusso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks. The PR looks great, thanks for making the JIT so much clearer to reason about.

brandtbucher reacted with heart emoji
@brandtbucherbrandtbucher merged commit3d8c38f intopython:mainJul 14, 2025
66 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@diegorussodiegorussodiegorusso approved these changes

@savannahostrowskisavannahostrowskiAwaiting requested review from savannahostrowskisavannahostrowski is a code owner

Assignees

@brandtbucherbrandtbucher

Labels
interpreter-core(Objects, Python, Grammar, and Parser dirs)performancePerformance or resource usageskip newstopic-JIT
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@brandtbucher@Fidget-Spinner@diegorusso

[8]ページ先頭

©2009-2025 Movatter.jp