Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-127146: Report uid in Emscripten + node as native uid#136509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

hoodmane
Copy link
Contributor

@hoodmanehoodmane commentedJul 10, 2025•
edited by bedevere-appbot
Loading

Fixestest_netrc.NetrcTestCase.test_security, which was getting mad that we reported the uid of a file correctly but reported the user's uid as 0.

cc@freakboy3742.

cmaloney reacted with thumbs up emoji
Fixes `test_netrc.NetrcTestCase.test_security`, which was getting madthat we reported the uid of a file correctly but reported the user's uidas 0.
@freakboy3742
Copy link
Contributor

!buildbot emscripten

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by@freakboy3742 for commitf2a7202 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F136509%2Fmerge

The command will test the builders whose names match following regular expression:emscripten

The builders matched are:

  • WASM Emscripten PR

@freakboy3742
Copy link
Contributor

freakboy3742 commentedJul 11, 2025•
edited
Loading

The buildbotisn't happy with the new C file...

@hoodmane
Copy link
ContributorAuthor

Indeed, there is a missing#include.
!buildbot emscripten

@hoodmane
Copy link
ContributorAuthor

How do the!buildbot pragmas work? I don't find a section the devguidehttps://devguide.python.org/testing/buildbots/ Maybe we should add a paragraph there explaining.

@freakboy3742
Copy link
Contributor

!buildbot emscripten

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by@freakboy3742 for commit789681e 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F136509%2Fmerge

The command will test the builders whose names match following regular expression:emscripten

The builders matched are:

  • WASM Emscripten PR

@freakboy3742
Copy link
Contributor

How do the!buildbot pragmas work? I don't find a section the devguidehttps://devguide.python.org/testing/buildbots/ Maybe we should add a paragraph there explaining.

I'm not sure if the buildbot issue is a permissions thing, or if the buildbot directive has to be a comment on its own. I've asked on Discord for clarification; in the meantime, I've kicked off a build for you.

Copy link
Contributor

@freakboy3742freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks like that has done the job!

@freakboy3742freakboy3742enabled auto-merge (squash)July 14, 2025 02:47
@freakboy3742
Copy link
Contributor

Looks like it still isn't happy - I thought the "up-to-date" error was a configure.ac thing, but it looks like a linting check on the new C file...

@zware
Copy link
Member

the buildbot directive has to be a comment on its own

^ this, or at least the comment has to start with the buildbot command.

Improvements welcome :)

@hoodmane
Copy link
ContributorAuthor

!buildbot emscripten

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by@hoodmane for commitb8df7ea 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F136509%2Fmerge

The command will test the builders whose names match following regular expression:emscripten

The builders matched are:

  • WASM Emscripten PR

@freakboy3742
Copy link
Contributor

!buildbot ios|android

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by@freakboy3742 for commitb8df7ea 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F136509%2Fmerge

The command will test the builders whose names match following regular expression:ios|android

The builders matched are:

  • aarch64 Android PR
  • iOS ARM64 Simulator PR
  • AMD64 Android PR

@freakboy3742
Copy link
Contributor

!buildbot this-doesnt-exist

@bedevere-bot
Copy link

The regex 'this-doesnt-exist' did not match any buildbot builder. Is the requested builder in the list of stable builders?

@freakboy3742
Copy link
Contributor

(The buildbot trigger noise was part of testingpython/devguide#1605; the iOS/Android builds aren't actually required for testing)

@freakboy3742
Copy link
Contributor

With the platform specific exclusion in the c-analyzer, this is now passing the netrc test; we're down to just the pydoc test failure.

@freakboy3742freakboy3742 merged commite81c4e8 intopython:mainJul 16, 2025
43 of 44 checks passed
@miss-islington-app
Copy link

Thanks@hoodmane for the PR, and@freakboy3742 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestJul 16, 2025
…nGH-136509)Corrects the handling of getuid on emscripten, which was consistently reporting as 0.(cherry picked from commite81c4e8)Co-authored-by: Hood Chatham <roberthoodchatham@gmail.com>
@bedevere-app
Copy link

GH-136699 is a backport of this pull request to the3.14 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.14bugs and security fixes labelJul 16, 2025
freakboy3742 pushed a commit that referenced this pull requestJul 16, 2025
…36509) (#136699)Corrects the handling of getuid on emscripten, which was consistently reporting as 0.(cherry picked from commite81c4e8)Co-authored-by: Hood Chatham <roberthoodchatham@gmail.com>
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure⚠️⚠️⚠️

Hi! The buildbotARM Raspbian Linux Asan 3.x (no tier) has failed when building commite81c4e8.

What do you need to do:

  1. Don't panic.
  2. Checkthe buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1811/builds/33) and take a look at the build logs.
  4. Check if the failure is related to this commit (e81c4e8) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1811/builds/33

Summary of the results of the build (if available):

Click to see traceback logs
remote:Enumerating objects: 10, done.remote:Counting objects:  12% (1/8)remote:Counting objects:  25% (2/8)remote:Counting objects:  37% (3/8)remote:Counting objects:  50% (4/8)remote:Counting objects:  62% (5/8)remote:Counting objects:  75% (6/8)remote:Counting objects:  87% (7/8)remote:Counting objects: 100% (8/8)remote:Counting objects: 100% (8/8), done.remote:Compressing objects:  16% (1/6)remote:Compressing objects:  33% (2/6)remote:Compressing objects:  50% (3/6)remote:Compressing objects:  66% (4/6)remote:Compressing objects:  83% (5/6)remote:Compressing objects: 100% (6/6)remote:Compressing objects: 100% (6/6), done.remote:Total 10 (delta 2), reused 2 (delta 2), pack-reused 2 (from 2)From https://github.com/python/cpython * branch                    main       -> FETCH_HEADNote:switching to 'e81c4e84b3a8688a367099e3adf9b2fcf914447f'.You are in 'detached HEAD' state. You can look around, make experimentalchanges and commit them, and you can discard any commits you make in thisstate without impacting any branches by switching back to a branch.If you want to create a new branch to retain commits you create, you maydo so (now or later) by using -c with the switch command. Example:  git switch -c <new-branch-name>Or undo this operation with:  git switch -Turn off this advice by setting config variable advice.detachedHead to falseHEAD is now at e81c4e84b3a gh-127146: Report uid in Emscripten + node as native uid (#136509)Switched to and reset branch 'main'configure:WARNING: no system libmpdec found; falling back to pure-Python version for the decimal moduleIn file included from ./Include/internal/pycore_dict.h:11,from Objects/typeobject.c:7:In function ‘Py_DECREF_MORTAL’,    inlinedfrom ‘PyStackRef_XCLOSE’ at ./Include/internal/pycore_stackref.h:730:9,    inlinedfrom ‘_PyThreadState_PopCStackRef’ at ./Include/internal/pycore_stackref.h:810:5,    inlinedfrom ‘vectorcall_maybe’ at Objects/typeobject.c:3103:9:./Include/internal/pycore_object.h:481:8: warning: array subscript 0 is outside array bounds of ‘PyObject[0]’ {aka ‘struct _object[]’} [-Warray-bounds]  481 |     if (--op->ob_refcnt == 0) {|^Timeout (0:05:00)!Thread 0x0000007f8c2ef100 [Thread-2] (most recent call first):  File "/home/buildbot/buildarea/3.x.pablogsal-rasp.asan/build/Lib/subprocess.py", line 2021 in _try_wait  File "/home/buildbot/buildarea/3.x.pablogsal-rasp.asan/build/Lib/subprocess.py", line 2046 in _wait  File "/home/buildbot/buildarea/3.x.pablogsal-rasp.asan/build/Lib/subprocess.py", line 1277 in wait  File "/home/buildbot/buildarea/3.x.pablogsal-rasp.asan/build/Lib/test/libregrtest/run_workers.py", line 194 in _run_process  File "/home/buildbot/buildarea/3.x.pablogsal-rasp.asan/build/Lib/test/libregrtest/run_workers.py", line 299 in run_tmp_files  File "/home/buildbot/buildarea/3.x.pablogsal-rasp.asan/build/Lib/test/libregrtest/run_workers.py", line 363 in _runtest  File "/home/buildbot/buildarea/3.x.pablogsal-rasp.asan/build/Lib/test/libregrtest/run_workers.py", line 403 in run  File "/home/buildbot/buildarea/3.x.pablogsal-rasp.asan/build/Lib/threading.py", line 1074 in _bootstrap_inner  File "/home/buildbot/buildarea/3.x.pablogsal-rasp.asan/build/Lib/threading.py", line 1036 in _bootstrapThread 0x0000007f8caff100 [Thread-1] (most recent call first):  File "/home/buildbot/buildarea/3.x.pablogsal-rasp.asan/build/Lib/subprocess.py", line 2018 in _try_wait  File "/home/buildbot/buildarea/3.x.pablogsal-rasp.asan/build/Lib/subprocess.py", line 2046 in _wait  File "/home/buildbot/buildarea/3.x.pablogsal-rasp.asan/build/Lib/subprocess.py", line 1277 in wait  File "/home/buildbot/buildarea/3.x.pablogsal-rasp.asan/build/Lib/test/libregrtest/run_workers.py", line 194 in _run_process  File "/home/buildbot/buildarea/3.x.pablogsal-rasp.asan/build/Lib/test/libregrtest/run_workers.py", line 299 in run_tmp_files  File "/home/buildbot/buildarea/3.x.pablogsal-rasp.asan/build/Lib/test/libregrtest/run_workers.py", line 363 in _runtest  File "/home/buildbot/buildarea/3.x.pablogsal-rasp.asan/build/Lib/test/libregrtest/run_workers.py", line 403 in run  File "/home/buildbot/buildarea/3.x.pablogsal-rasp.asan/build/Lib/threading.py", line 1074 in _bootstrap_inner  File "/home/buildbot/buildarea/3.x.pablogsal-rasp.asan/build/Lib/threading.py", line 1036 in _bootstrapThread 0x0000007f988656c0 [python] (most recent call first):  File "/home/buildbot/buildarea/3.x.pablogsal-rasp.asan/build/Lib/queue.py", line 214 in get  File "/home/buildbot/buildarea/3.x.pablogsal-rasp.asan/build/Lib/test/libregrtest/run_workers.py", line 541 in _get_result  File "/home/buildbot/buildarea/3.x.pablogsal-rasp.asan/build/Lib/test/libregrtest/run_workers.py", line 610 in run  File "/home/buildbot/buildarea/3.x.pablogsal-rasp.asan/build/Lib/test/libregrtest/main.py", line 455 in _run_tests_mp  File "/home/buildbot/buildarea/3.x.pablogsal-rasp.asan/build/Lib/test/libregrtest/main.py", line 561 in _run_tests  File "/home/buildbot/buildarea/3.x.pablogsal-rasp.asan/build/Lib/test/libregrtest/main.py", line 598 in run_tests  File "/home/buildbot/buildarea/3.x.pablogsal-rasp.asan/build/Lib/test/libregrtest/main.py", line 767 in main  File "/home/buildbot/buildarea/3.x.pablogsal-rasp.asan/build/Lib/test/libregrtest/main.py", line 775 in main  File "/home/buildbot/buildarea/3.x.pablogsal-rasp.asan/build/Lib/test/__main__.py", line 2 in <module>  File "<frozen runpy>", line 88 in _run_code  File "<frozen runpy>", line 198 in _run_module_as_mainmake:*** [Makefile:2460: buildbottest] Error 1Cannot open file '/home/buildbot/buildarea/3.x.pablogsal-rasp.asan/build/test-results.xml' for upload

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@freakboy3742freakboy3742freakboy3742 approved these changes

@erlend-aaslanderlend-aaslandAwaiting requested review from erlend-aaslanderlend-aasland is a code owner

@corona10corona10Awaiting requested review from corona10corona10 is a code owner

@ericsnowcurrentlyericsnowcurrentlyAwaiting requested review from ericsnowcurrentlyericsnowcurrently is a code owner

Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@hoodmane@freakboy3742@bedevere-bot@zware
[8]ページ先頭
©2009-2025 Movatter.jp