Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.4k
gh-134043: use_Py_dict_lookup_unicode_threadsafe_stackref for dict lookup in_PyObject_GetMethodStackRef#136412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
kumaraditya303 wants to merge9 commits intopython:mainChoose a base branch
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
+84 −11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
- We should add a scaling benchmark to
ftscalingbench.pyfor the relevant access pattern - We probably need to avoid
Py_INCREF(dict)and that's going to require refactoring. You can safely avoidPy_INCREF(dict)in the same cases where_Py_dict_lookup_threadsafe_stackrefis relevant: when the dictionary keys areDICT_KEYS_UNICODE.
Uh oh!
There was an error while loading.Please reload this page.
This needs more refactoring - we can't load the keys twice like this because the condition might not hold. |
_Py_dict_lookup_threadsafe_stackref for dict lookup in_PyObject_GetMethodStackRef_Py_dict_lookup_unicode_threadsafe_stackref for dict lookup in_PyObject_GetMethodStackRefSign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
_PyObject_GetMethodand calling APIs #134043Changes
_PyObject_GetMethodStackRefto use_Py_dict_lookup_threadsafe_stackrefto avoid reference counting on deferred objects.