NotificationsYou must be signed in to change notification settings
Fork32.4k
Star67.9k

gh-136327: Fix inconsistent TypeError messages regarding invalid values after * and **#136395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Open

Tapeline wants to merge3 commits intopython:main

base:main

Choose a base branch

fromTapeline:fix-gh-136327

Open

gh-136327: Fix inconsistent TypeError messages regarding invalid values after * and **#136395

Tapeline wants to merge3 commits intopython:mainfromTapeline:fix-gh-136327

Conversation

Copy link

Contributor

Tapeline commentedJul 7, 2025•
edited by bedevere-appbot
Loading

Solved removing function name from error message entirely

Issue:Inconsistent TypeError messages with callables #136327

Tapeline added2 commits

July 8, 2025 00:42

Remove callable name from TypeError messages with invalid values afte…

35c6097

…r * and **

Merge branch 'refs/heads/main' into fix-pythongh-136327

c9a6ac9

Tapeline requested a review frommarkshannon as acode owner

July 7, 2025 19:47

bedevere-appbot added the awaiting review label

Jul 7, 2025

Copy link

python-cla-botbot commentedJul 7, 2025•
edited
Loading

All commit authors signed the Contributor License Agreement.

Tapeline changed the titlegh-12345: Fix inconsistent TypeError messages regarding invalid values after * and **gh-136327: Fix inconsistent TypeError messages regarding invalid values after * and **

Jul 7, 2025

bedevere-appbot mentioned this pull request

Jul 7, 2025

Inconsistent TypeError messages with callables#136327

Open

sobolevn reviewed

Jul 7, 2025

View reviewed changes

Python/ceval.cShow resolvedHide resolved

sergey-miryanov reviewed

Jul 8, 2025

View reviewed changes

Python/ceval.c

		funcstr, Py_TYPE(args)->tp_name);
		Py_DECREF(funcstr);
		}
		_PyErr_Format(tstate, PyExc_TypeError,

Copy link

Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Why not to use %T formatter here? IIUC it is preferable now.

Copy link

ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Nikita's suggestions on removing the function name entirely were motivated by the fact that getting this name is not fast and does not add much value (in fact, none at all). I've looked into the %T specification, and it seems to do x2 of work we just got rid of, so I doubt that that would be a positive change. Anyway, we're waiting on Mark's review on that, maybe he has another opinion