Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.7k
gh-135552: Add tests that check if weakref for tp_subclasses cleared after finalization#136304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
nascheme merged 13 commits intopython:mainfromsergey-miryanov:gh-135552-add-tests-gc-weakref-tp_subclassesAug 8, 2025
Uh oh!
There was an error while loading.Please reload this page.
Merged
Changes from1 commit
Commits
Show all changes
13 commits Select commitHold shift + click to select a range
4d648b4 Add tests
fxeqxmulfx77e9ca7 Organize tests
sergey-miryanovb6825da Simplify tests
sergey-miryanovf62d43e Remove extra line
sergey-miryanov398c4f5 Add extra comments
sergey-miryanov7dd9669 Add tests for checking that weakrefs clears before and after finaliza…
sergey-miryanov1da73b3 Make tests a little bit reliable
sergey-miryanov0510539 Simplify tests
sergey-miryanov50410d6 Use unittest asserts
sergey-miryanovaa18e74 Move test_clearing_weakrefs_in_gc to test_weakref
sergey-miryanov7788e55 Apply suggestions from code review
sergey-miryanovd125d06 Merge branch 'main' into gh-135552-add-tests-gc-weakref-tp_subclasses
nascheme0339d54 Revise test_clearing_weakrefs_in_gc test
naschemeFile filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
Add tests for checking that weakrefs clears before and after finaliza…
…tion
- Loading branch information
Uh oh!
There was an error while loading.Please reload this page.
commit7dd966925f469f715b1503bf44954ab002ac47d0
There are no files selected for viewing
45 changes: 45 additions & 0 deletionsLib/test/test_gc.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1156,6 +1156,51 @@ def test(): | ||
| # this test checks regular garbage collection | ||
| assert_python_ok("-c", code_inside_function) | ||
| def test_type_weakref_with_callback_should_be_none(self): | ||
| # This test checks that weakrefs for types with callbacks | ||
| # are cleared before the finalizer is called | ||
| code = """ | ||
| import weakref | ||
| def test(): | ||
| class Class: | ||
| def __init__(self): | ||
| self._self = self | ||
| self._z = weakref.ref(Class, lambda x: None) | ||
| def __del__(self): | ||
| assert self._z() is None, "Type weakref is not None" | ||
| Class() | ||
| test() | ||
| """ | ||
| _, _, stderr = assert_python_ok("-c", code) | ||
| assert b"Type weakref is not None" not in stderr | ||
| def test_type_weakref_without_callback_should_be_not_none(self): | ||
| # This test checks that weakrefs for types without callbacks | ||
| # are cleared after the finalizer is called | ||
| code = """ | ||
| import weakref | ||
| def test(): | ||
| class Class: | ||
| def __init__(self): | ||
| self._self = self | ||
| self._x = weakref.ref(self) | ||
| self._z = weakref.ref(Class) | ||
| def __del__(self): | ||
| assert self._x() is None, "Instance weakref is not None" | ||
| assert self._z() is Class, "Type weakref is not Class" | ||
| Class() | ||
| test() | ||
| """ | ||
| _, _, stderr = assert_python_ok("-c", code) | ||
| assert b"Instance weakref is not None" not in stderr | ||
| assert b"Type weakref is not Class" not in stderr | ||
sergey-miryanov marked this conversation as resolved. OutdatedShow resolvedHide resolvedUh oh!There was an error while loading.Please reload this page. | ||
| class IncrementalGCTests(unittest.TestCase): | ||
| @unittest.skipIf(_testinternalcapi is None, "requires _testinternalcapi") | ||
Oops, something went wrong.
Uh oh!
There was an error while loading.Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.