Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.4k
[3.10] gh-135661: Fix parsing start and end tags in HTMLParser according to the HTML5 standard (GH-135930) (GH-136268)#136292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
…according to the HTML5 standard (pythonGH-135930) (pythonGH-136268)* Whitespaces no longer accepted between `</` and the tag name. E.g. `</ script>` does not end the script section.* Vertical tabulation (`\v`) and non-ASCII whitespaces no longer recognized as whitespaces. The only whitespaces are `\t\n\r\f `.* Null character (U+0000) no longer ends the tag name.* Attributes and slashes after the tag name in end tags are now ignored, instead of terminating after the first `>` in quoted attribute value. E.g. `</script/foo=">"/>`.* Multiple slashes and whitespaces between the last attribute and closing `>` are now ignored in both start and end tags. E.g. `<a foo=bar/ //>`.* Multiple `=` between attribute name and value are no longer collapsed. E.g. `<a foo==bar>` produces attribute "foo" with value "=bar".* Whitespaces between the `=` separator and attribute name or value are no longer ignored. E.g. `<a foo =bar>` produces two attributes "foo" and "=bar", both with value None; `<a foo= bar>` produces two attributes: "foo" with value "" and "bar" with value None.* Fix data loss after unclosed script or style tag (pythongh-86155).Also backport test.support.subTests() (pythongh-135120).---------(cherry picked from commit0243f97)(cherry picked from commitc555f88)Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>Co-authored-by: Waylan Limberg <waylan.limberg@icloud.com>
ezio-melotti approved these changesJul 4, 2025
151e0f0 intopython:3.10 15 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Whitespaces no longer accepted between
</and the tag name.E.g.
</ script>does not end the script section.Vertical tabulation (
\v) and non-ASCII whitespaces no longer recognizedas whitespaces. The only whitespaces are
\t\n\r\f.Null character (U+0000) no longer ends the tag name.
Attributes and slashes after the tag name in end tags are now ignored,
instead of terminating after the first
>in quoted attribute value.E.g.
</script/foo=">"/>.Multiple slashes and whitespaces between the last attribute and closing
>are now ignored in both start and end tags. E.g.
<a foo=bar/ //>.Multiple
=between attribute name and value are no longer collapsed.E.g.
<a foo==bar>produces attribute "foo" with value "=bar".Whitespaces between the
=separator and attribute name or value are nolonger ignored. E.g.
<a foo =bar>produces two attributes "foo" and"=bar", both with value None;
<a foo= bar>produces two attributes:"foo" with value "" and "bar" with value None.
Fix data loss after unclosed script or style tag (htmlparser unclosed script tag causes data loss #86155).
Also backport test.support.subTests() (gh-135120).
(cherry picked from commit0243f97)
(cherry picked from commitc555f88)
Co-authored-by: Serhiy Storchakastorchaka@gmail.com
Co-authored-by: Ezio Melottiezio.melotti@gmail.com
Co-authored-by: Waylan Limbergwaylan.limberg@icloud.com