Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork34.1k
Comments
gh-136285: Improvepickle protocol testing intest_interpreters#136286
Merged
sobolevn merged 4 commits intopython:mainfromJul 6, 2025
Merged
gh-136285: Improvepickle protocol testing intest_interpreters#136286sobolevn merged 4 commits intopython:mainfrom
pickle protocol testing intest_interpreters#136286sobolevn merged 4 commits intopython:mainfrom
Conversation
serhiy-storchaka approved these changesJul 4, 2025
Member
serhiy-storchaka left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM. 👍
Member
serhiy-storchaka commentedJul 4, 2025
It looks that there is a bug. So it is better to fix it first and then run tests for all protocols. |
serhiy-storchaka approved these changesJul 5, 2025
Member
serhiy-storchaka left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM. 👍
This is the right way that preserves the same semantic as for protocols >= 2.
Uh oh!
There was an error while loading.Please reload this page.
06e347b intopython:main 40 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Thanks@sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestJul 6, 2025
…ers` (pythonGH-136286)(cherry picked from commit06e347b)Co-authored-by: sobolevn <mail@sobolevn.me>
GH-136333 is a backport of this pull request to the3.14 branch. |
sobolevn added a commit that referenced this pull requestJul 6, 2025
AndPuQing pushed a commit to AndPuQing/cpython that referenced this pull requestJul 11, 2025
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull requestJul 12, 2025
picnixz pushed a commit to picnixz/cpython that referenced this pull requestJul 13, 2025
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull requestAug 4, 2025
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull requestAug 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
test_interpretersmisses tests with allpickleprotocols #136285