Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-136285: Improvepickle protocol testing intest_interpreters#136286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
sobolevn merged 4 commits intopython:mainfromsobolevn:issue-136285
Jul 6, 2025

Conversation

@sobolevn
Copy link
Member

@sobolevnsobolevn commentedJul 4, 2025•
edited by bedevere-appbot
Loading

Copy link
Member

@serhiy-storchakaserhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM. 👍

@serhiy-storchaka
Copy link
Member

It looks that there is a bug. So it is better to fix it first and then run tests for all protocols.

@sobolevnsobolevn added the needs backport to 3.14bugs and security fixes labelJul 5, 2025
@sobolevnsobolevn removed skip news testsTests in the Lib/test dir labelsJul 5, 2025
Copy link
Member

@serhiy-storchakaserhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM. 👍

This is the right way that preserves the same semantic as for protocols >= 2.

@sobolevnsobolevnenabled auto-merge (squash)July 6, 2025 07:10
@sobolevnsobolevn merged commit06e347b intopython:mainJul 6, 2025
40 checks passed
@miss-islington-app
Copy link

Thanks@sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestJul 6, 2025
…ers` (pythonGH-136286)(cherry picked from commit06e347b)Co-authored-by: sobolevn <mail@sobolevn.me>
@bedevere-app
Copy link

GH-136333 is a backport of this pull request to the3.14 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.14bugs and security fixes labelJul 6, 2025
sobolevn added a commit that referenced this pull requestJul 6, 2025
…ters` (GH-136286) (#136333)gh-136285: Improve `pickle` protocol testing in `test_interpreters` (GH-136286)(cherry picked from commit06e347b)Co-authored-by: sobolevn <mail@sobolevn.me>
AndPuQing pushed a commit to AndPuQing/cpython that referenced this pull requestJul 11, 2025
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull requestJul 12, 2025
picnixz pushed a commit to picnixz/cpython that referenced this pull requestJul 13, 2025
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull requestAug 4, 2025
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull requestAug 19, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@serhiy-storchakaserhiy-storchakaserhiy-storchaka approved these changes

@ericsnowcurrentlyericsnowcurrentlyAwaiting requested review from ericsnowcurrentlyericsnowcurrently is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sobolevn@serhiy-storchaka
[8]ページ先頭
©2009-2025 Movatter.jp