Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-133644: RemovePySys_SetArgv* for 3.15#136277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
xuantengh wants to merge4 commits intopython:main
base:main
Choose a base branch
Loading
fromxuantengh:deprecate-pysys_set

Conversation

xuantengh
Copy link
Contributor

@xuantenghxuantengh commentedJul 4, 2025•
edited by bedevere-appbot
Loading

@xuantenghxuantengh changed the titleRemovePySys_SetArgv* for 3.15gh-133644: RemovePySys_SetArgv* for 3.15Jul 4, 2025
Comment on lines 1338 to 1341
[function.PySys_SetArgv]
added = '3.2'
[function.PySys_SetArgvEx]
added = '3.2'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

We shouldn't remove the entry here, we should just mark them asabi_only = true.

zooba reacted with thumbs up emoji
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Which will preserve them inpython3dll.c, which is theactual breaking change (or at least the one that can be easily seen in a source diff).

Arguably they should stay in the header files as well, possibly only whenPy_LIMITED_API is set. The functionality can change if it needs to, though ideally wouldn't break every existing user.

@picnixz
Copy link
Member

Please check if there are projects in the wild that use this. See for instance the case of PyWeakRef_GetObject where we delayed the removal for now until less projects are using it. And also, we should coordinate with the compat project. Finally, add a section for this removal in What's New as well as possible fallbacks.

xuantengh reacted with thumbs up emoji

@xuantengh
Copy link
ContributorAuthor

xuantengh commentedJul 5, 2025•
edited
Loading

Please check if there are projects in the wild that use this.

I have some rough and preliminary search in GitHub and find some projects like:

still use these C functions.

I can have a more detail exploration for popular PyPI packages later.

@xuantengh
Copy link
ContributorAuthor

@picnixz I search the top 300 popular PyPI packages and findPySys_SetArgv appears in the following 2:

@picnixz
Copy link
Member

picnixz commentedJul 8, 2025•
edited
Loading

Well cython is a major project that we don't want to break. orjson is, iirc, simd-accelerated JSON so we don't want to break it either. They should first upgrade their code and then we'll remove the functions on our side I think.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@zoobazoobazooba left review comments

@ZeroIntensityZeroIntensityZeroIntensity left review comments

@encukouencukouAwaiting requested review from encukouencukou is a code owner

@ericsnowcurrentlyericsnowcurrentlyAwaiting requested review from ericsnowcurrentlyericsnowcurrently is a code owner

Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@xuantengh@picnixz@zooba@ZeroIntensity
[8]ページ先頭
©2009-2025 Movatter.jp