Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-101100: Fix references in http.cookiejar docs #114658#136238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

LamentXU123
Copy link
Contributor

@LamentXU123LamentXU123 commentedJul 3, 2025•
edited by bedevere-appbot
Loading

Theorigial doc is:

image

Since there is no highlights or any reference, I see no reason to split the doc ofstrict_ns_domain. I think maybe we can make the description of the acceptable value just belowstrict_ns_domain? The two addtributes within are likely to be added in the wrong place.

Another thing is the referrence link ofstrict_ns_domain is invalid in the original doc, since it's been interrupted and can't locate the attribute. (The .rst file ishere)

This PR change it to:

image

Skipping issues and news ;)

📚 Documentation preview 📚:https://cpython-previews--136238.org.readthedocs.build/

Copy link
Member

@picnixzpicnixz left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Please keep it as is. The attributes documented after this "weird" paragraph are the flags. This paragraph serves as a separation between regulat attributes and class variable constants that behave like flags.

In the future, please first create an issue to discuss such changes before or carefully check that there is something to change.

Note: the backlink is an issue that can be solved by this PR but don't move around the docs. Just add the DefaultCookiePolicy namespace and the ~ to suppress the fully qualified name.

LamentXU123 reacted with heart emoji
@bedevere-app
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phraseI have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@picnixz
Copy link
Member

Use the issue that aims to remove warnings in the docs for this one.

@LamentXU123LamentXU123 changed the titleDoc: Fix interrupting words in doc ofDefaultCookiePolicy.strict_ns_domaingh-101100: Fix references in http.cookiejar docs #114658Jul 5, 2025
@LamentXU123
Copy link
ContributorAuthor

LamentXU123 commentedJul 5, 2025•
edited
Loading

Done. Thank you for your review.

image

@LamentXU123
Copy link
ContributorAuthor

I have made the requested changes; please review again

@bedevere-app
Copy link

Thanks for making the requested changes!

@picnixz: please review the changes made to this pull request.

@bedevere-appbedevere-appbot requested a review frompicnixzJuly 5, 2025 03:50
@picnixz
Copy link
Member

@ZeroIntensity Can you remove my old review and merge this one? TiA

LamentXU123 and ZeroIntensity reacted with heart emoji

Copy link
Member

@ZeroIntensityZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Silly bot

@ZeroIntensityZeroIntensity merged commitf0c7344 intopython:mainJul 5, 2025
31 of 33 checks passed
@github-project-automationgithub-project-automationbot moved this fromTodo toDone inDocs PRsJul 5, 2025
@ZeroIntensityZeroIntensity added awaiting merge needs backport to 3.13bugs and security fixes needs backport to 3.14bugs and security fixes labelsJul 5, 2025
@miss-islington-app
Copy link

Thanks@LamentXU123 for the PR, and@ZeroIntensity for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Thanks@LamentXU123 for the PR, and@ZeroIntensity for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestJul 5, 2025
…6238)(cherry picked from commitf0c7344)Co-authored-by: Weilin Du <108666168+LamentXU123@users.noreply.github.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestJul 5, 2025
…6238)(cherry picked from commitf0c7344)Co-authored-by: Weilin Du <108666168+LamentXU123@users.noreply.github.com>
@bedevere-app
Copy link

GH-136317 is a backport of this pull request to the3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13bugs and security fixes labelJul 5, 2025
@bedevere-app
Copy link

GH-136318 is a backport of this pull request to the3.14 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.14bugs and security fixes labelJul 5, 2025
ZeroIntensity pushed a commit that referenced this pull requestJul 5, 2025
…GH-136318)gh-101100: Fix references in `http.cookiejar` docs (GH-136238)(cherry picked from commitf0c7344)Co-authored-by: Weilin Du <108666168+LamentXU123@users.noreply.github.com>
ZeroIntensity pushed a commit that referenced this pull requestJul 5, 2025
…GH-136317)gh-101100: Fix references in `http.cookiejar` docs (GH-136238)(cherry picked from commitf0c7344)Co-authored-by: Weilin Du <108666168+LamentXU123@users.noreply.github.com>
AndPuQing pushed a commit to AndPuQing/cpython that referenced this pull requestJul 11, 2025
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull requestJul 12, 2025
picnixz pushed a commit to picnixz/cpython that referenced this pull requestJul 13, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@picnixzpicnixzpicnixz approved these changes

@ZeroIntensityZeroIntensityZeroIntensity approved these changes

Assignees
No one assigned
Labels
awaiting mergedocsDocumentation in the Doc dirskip news
Projects
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@LamentXU123@picnixz@ZeroIntensity
[8]ページ先頭
©2009-2025 Movatter.jp