Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.4k
gh-76535: MakePyUnicode_ToLowerFull
and friends public#136176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Make `PyUnicode_ToLowerFull`, `PyUnicode_ToUpperFull` and`PyUnicode_ToTitleFull` public and rename them to `PyUnicode_ToLower`etc.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Thanks for taking a look@vstinner! Feedback addressed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
In#76535 (comment)@vstinner suggested to provide a constant which is the minimum buffer size.
If this is indeed a hard constant which will never be changed in future Unicode standards, then I prefer this way. It is too expensive to allocate the output buffer dynamically.
cc@ezio-melotti, our Unicode expert.
Another question I have is whether we want to expose something like the following to handle the Greek letter sigma edge case: intPyUnicode_ToLowerHandleSigma(Py_UCS4*str,Py_UCS4ch,Py_UCS4*buffer,intsize) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks, I prefer this API which is more future-proof, it doesn't depend on a specific Unicode version.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Would you mind to elaborate? I'm not aware of this special case. |
Even if it's a constant which will never (!) change, IMO it's better to request a size as an argument to make the caller responsible to check the buffer size. APIs which accept a pointer with no size are a bad pattern, like the deprecated gets() function. |
Further feedback addressed.
There's one special case, the Greek letter sigma, where the result of lower casing is context-specific. More specifically, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Can you try to add tests toModules/_testcapi/unicode.c
andLib/test/test_capi/test_unicode.py
?
Uh oh!
There was an error while loading.Please reload this page.
Oh, that's a tricky case. Proposed API takes a single character, so we don't know if Σ is at the end of a word or not. I don't think that it's worth it to handle this special case in proposed API. |
Done. |
If we add too many parameters and runtime checks, this will make the API slower and more difficult to use. |
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Co-authored-by: Victor Stinner <vstinner@python.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM, I just have some minor comments.
@serhiy-storchaka: Would you be ok with this approach? An API with asize parameter.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
All feedback addressed! Thanks for all the help and patience@vstinner! |
Friendly ping. |
Uh oh!
There was an error while loading.Please reload this page.
Make
_PyUnicode_ToLowerFull
,_PyUnicode_ToUpperFull
,_PyUnicode_ToTitleFull
and_PyUnicode_ToFoldedFull
public and rename them toPyUnicode_ToLower
etc.📚 Documentation preview 📚:https://cpython-previews--136176.org.readthedocs.build/