Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add @maxking to CODEOWNERS file#13599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
miss-islington merged 1 commit intopython:masterfrommaxking:codeowner
May 28, 2019

Conversation

@maxking
Copy link
Contributor

@maxkingmaxking commentedMay 27, 2019
edited by Mariatta
Loading

No description provided.

@Mariatta
Copy link
Member

Hmm we've never tried adding non core developers intoCODEOWNERS yet, so I'm not sure if this will work. The effect ofcodeowners file is that you will be automatically requested review for the matched PR, and I don't know if we can request review from people outside of Python org.

But anyway, let's try this, and we can always revert the change.

@MariattaMariatta changed the titleAdd myself to CODEOWNERS for email module.Add @maxking to CODEOWNERS fileMay 28, 2019
@miss-islingtonmiss-islington merged commit71dc7c5 intopython:masterMay 28, 2019
@maxkingmaxking deleted the codeowner branchMay 28, 2019 04:20
@maxking
Copy link
ContributorAuthor

Thanks@Mariatta ! Now all I need to do is open a PR and see if it works ;-)

Mariatta reacted with thumbs up emoji

@tirkarthi
Copy link
Member

https://help.github.com/en/articles/about-code-owners

People with admin or owner permissions can set up a CODEOWNERS file in a repository. The people you choose as code owners must have write permissions for the repository.

brettcannon added a commit that referenced this pull requestMay 28, 2019
@brettcannon
Copy link
Member

I opened#13660 to revert this since@tirkarthi found that reference saying@maxking would need to have write access to get notifications.

Maybe once the new "triage" access is launched that will work with CODEOWNERS and then we can give@maxking that level of access.

Mariatta, maxking, and tirkarthi reacted with thumbs up emoji

DinoV pushed a commit to DinoV/cpython that referenced this pull requestJan 14, 2020
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@MariattaMariattaMariatta approved these changes

+1 more reviewer

@eamanueamanueamanu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@maxking@Mariatta@tirkarthi@brettcannon@eamanu@the-knights-who-say-ni@bedevere-bot@miss-islington

[8]ページ先頭

©2009-2025 Movatter.jp