Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.3k
Add @maxking to CODEOWNERS file#13599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Mariatta commentedMay 28, 2019
Hmm we've never tried adding non core developers into But anyway, let's try this, and we can always revert the change. |
maxking commentedMay 28, 2019
Thanks@Mariatta ! Now all I need to do is open a PR and see if it works ;-) |
tirkarthi commentedMay 28, 2019
https://help.github.com/en/articles/about-code-owners
|
brettcannon commentedMay 29, 2019
I opened#13660 to revert this since@tirkarthi found that reference saying@maxking would need to have write access to get notifications. Maybe once the new "triage" access is launched that will work with CODEOWNERS and then we can give@maxking that level of access. |
Uh oh!
There was an error while loading.Please reload this page.
No description provided.