Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

gh-111758: Run UBSan in GitHub Actions#135578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
encukou merged 7 commits intopython:mainfromencukou:gha-ubsan
Jun 19, 2025
Merged

Conversation

encukou
Copy link
Member

@encukouencukou commentedJun 16, 2025
edited by bedevere-appbot
Loading

This adds a--with-undefined-behavior-sanitizer CI run, modeled after the TSan one.

The runtime should beless than 13 minutes, well below Windows runs.

Copy link
Member

@hugovkhugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

There's a lot of duplicate boilerplate inreusable-tsan.yml andreusable-ubsan.yml, we can combine them into a single reusable workflow, and reduce future maintenance.

Something like this:hugovk@39f6c91

Note this is from this morning, and doesn't include your three recent commits.

I'm also happy to do this in a followup if you prefer.

Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@encukou
Copy link
MemberAuthor

I'm also happy to do this in a followup if you prefer.

Yes, I think it's better as a follow-up. Maybe in a week or so, to let the job settle down? It's easier to edit an independent copy :)
Thank you for starting on it though!

hugovk reacted with thumbs up emoji

uses: actions/cache@v4
with:
path: config.cache
key: ${{ github.job }}-${{ env.IMAGE_OS_VERSION }}-${{ inputs.config_hash }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I think the configure failure:

https://github.com/python/cpython/actions/runs/15706865183/job/44254688889?pr=135578

is because this key is identical to the one inreusable-tsan.yml, so let's addubsan or something in here:

Suggested change
key:${{ github.job }}-${{ env.IMAGE_OS_VERSION }}-${{ inputs.config_hash }}
key:${{ github.job }}-ubsan-${{ env.IMAGE_OS_VERSION }}-${{ inputs.config_hash }}

Copy link
MemberAuthor

@encukouencukouJun 17, 2025
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

ubsan is part ofgithub.job. It's using a cache from before I added the latest commits.
I removed that cache and will restart the job. (GitHub will allow that after all the other ones finish).

hugovk reacted with thumbs up emoji
@encukouencukou merged commit7a20c72 intopython:mainJun 19, 2025
39 checks passed
lkollar pushed a commit to lkollar/cpython that referenced this pull requestJun 19, 2025
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull requestJul 12, 2025
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@hugovkhugovkhugovk left review comments

@thesamesamthesamesamthesamesam left review comments

@ezio-melottiezio-melottiAwaiting requested review from ezio-melottiezio-melotti is a code owner

@AA-TurnerAA-TurnerAwaiting requested review from AA-TurnerAA-Turner is a code owner

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@encukou@hugovk@thesamesam

[8]ページ先頭

©2009-2025 Movatter.jp