Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.4k
gh-111758: Run UBSan in GitHub Actions#135578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
There's a lot of duplicate boilerplate inreusable-tsan.yml
andreusable-ubsan.yml
, we can combine them into a single reusable workflow, and reduce future maintenance.
Something like this:hugovk@39f6c91
Note this is from this morning, and doesn't include your three recent commits.
I'm also happy to do this in a followup if you prefer.
Uh oh!
There was an error while loading.Please reload this page.
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Yes, I think it's better as a follow-up. Maybe in a week or so, to let the job settle down? It's easier to edit an independent copy :) |
uses: actions/cache@v4 | ||
with: | ||
path: config.cache | ||
key: ${{ github.job }}-${{ env.IMAGE_OS_VERSION }}-${{ inputs.config_hash }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I think the configure failure:
https://github.com/python/cpython/actions/runs/15706865183/job/44254688889?pr=135578
is because this key is identical to the one inreusable-tsan.yml
, so let's addubsan
or something in here:
key:${{ github.job }}-${{ env.IMAGE_OS_VERSION }}-${{ inputs.config_hash }} | |
key:${{ github.job }}-ubsan-${{ env.IMAGE_OS_VERSION }}-${{ inputs.config_hash }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
ubsan
is part ofgithub.job
. It's using a cache from before I added the latest commits.
I removed that cache and will restart the job. (GitHub will allow that after all the other ones finish).
7a20c72
intopython:mainUh oh!
There was an error while loading.Please reload this page.
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Uh oh!
There was an error while loading.Please reload this page.
This adds a
--with-undefined-behavior-sanitizer
CI run, modeled after the TSan one.The runtime should beless than 13 minutes, well below Windows runs.