Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.2k
gh-135532: module-wide cleanup for HACL*-based extension modules#135536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation
!buildbot FIPS only |
bedevere-bot commentedJun 15, 2025
🤖 New build scheduled with the buildbot fleet by@picnixz for commitabfa1af 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F135536%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
…135239# Conflicts:#Modules/_hashopenssl.c#Modules/blake2module.c
…135239# Conflicts:#Modules/hmacmodule.c
…135239# Conflicts:#Modules/hmacmodule.c
…135239# Conflicts:#Modules/md5module.c
Waiting for other PRs to be merged. Too many conflicts will appear otherwise. |
Ok some changes are not worth it at all. |
Moving code around is more likely to get me annoyed in the future so I won't do it. I had rewritten SHA-2 and SHA-3 but those as well could be dropped. |
Uh oh!
There was an error while loading.Please reload this page.
This is the first batch of cleanup. Honestly I'm sometimes lost when I navigate through files because MD5/SHA1/SHA2 have the same naming conventions, but SHA3 and BLAKE-2 have different conventions.
I've anyway introduced too many conflicts already compared to 3.14, so I don't think it'll become better. At least, when I work towards new features or bugfixes on the main branch, I won't be lost!
I will continue updating the comments as well. For now I've just move around some code and renamed some functions/attributes/variables. I find the naming
_blake2_traverseespecially confusing as it could have been both the module or the object traverse function!@gpshead are you ok with this "purely cosmetic" change which still improves maintainability? I can isolate the clinic directive updates which are real issues (but never caught because they are never used)